Merge lp://qastaging/~ubuntu-terminal-dev/ubuntu-terminal-app/fix-add-forceAuth into lp://qastaging/ubuntu-terminal-app
Proposed by
Carla Sella
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Nicholas Skaggs | ||||
| Approved revision: | 151 | ||||
| Merged at revision: | 153 | ||||
| Proposed branch: | lp://qastaging/~ubuntu-terminal-dev/ubuntu-terminal-app/fix-add-forceAuth | ||||
| Merge into: | lp://qastaging/ubuntu-terminal-app | ||||
| Diff against target: |
139 lines (+81/-3) 3 files modified
src/app/main.cpp (+22/-0) src/app/qml/AuthenticationService.qml (+1/-1) tests/autopilot/ubuntu_terminal_app/tests/__init__.py (+58/-2) |
||||
| To merge this branch: | bzr merge lp://qastaging/~ubuntu-terminal-dev/ubuntu-terminal-app/fix-add-forceAuth | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
| Alan Pope 🍺🐧🐱 🦄 | Pending | ||
| Nicholas Skaggs | Pending | ||
|
Review via email:
|
|||
Commit message
Add the --forceAuth flag to terminal-app
Description of the change
This should add the --forceAuth flag to launch the application bypassing the authentication.
Sadly tonight the emulator is not working for me so I could only check that the code actually compiles, so please use extra care.
To post a comment you must log in.
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:151
http://
Executed test runs:
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://