unity-2d

Merge lp://qastaging/~unity-2d-team/unity-2d/dash-not-dock into lp://qastaging/unity-2d/3.0

  1. dash-not-dock
  2. Merge into natty
Proposed by Ugo Riboni
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 531
Merged at revision: 530
Proposed branch: lp://qastaging/~unity-2d-team/unity-2d/dash-not-dock
Merge into: lp://qastaging/unity-2d/3.0
Diff against target: 110 lines (+37/-13)
2 files modified
places/app/dashdeclarativeview.cpp (+35/-13)
places/app/dashdeclarativeview.h (+2/-0)
To merge this branch: bzr merge lp://qastaging/~unity-2d-team/unity-2d/dash-not-dock
Reviewer Review Type Date Requested Status
Olivier Tilloy (community) Approve
Review via email: mp+57361@code.qastaging.launchpad.net

Description of the change

[dash] Make the dash a regular window without borders and request the WM not to show it in pagers.
This should hopefully make the situation a bit less confusing for metacity, and the dash-related corruption problems both with and without the metacity compositor active.

To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

/* Note that this has to be called everytime the window is shown, as the WM
   will to clean the flags when the window is hidden (whitdrawn) */

Grammar and spelling parser choked…

s/will to/will/
s/whitdrawn/withdrawn/

review: Needs Fixing
Revision history for this message
Olivier Tilloy (osomon) wrote :

- setGeometry(availableGeometry());
+ move(availableGeometry().topLeft());
+ setFixedSize(availableGeometry().size());

You’re calling availableGeometry() twice here, you should call it only once and assign the result to a local variable to re-use in the calls to move(…) and setFixedSize(…).

review: Needs Fixing
lp://qastaging/~unity-2d-team/unity-2d/dash-not-dock updated
531. By Ugo Riboni

Fix some code style, comments and other minor remarks from code review

Revision history for this message
Olivier Tilloy (osomon) wrote :

That works well, both with and without compositing enabled. Good job!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: