unity-2d

Merge lp://qastaging/~unity-2d-team/unity-2d/hud-redesign into lp://qastaging/unity-2d

  1. hud-redesign
  2. Merge into trunk
Proposed by Gerry Boland
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 1020
Merged at revision: 1029
Proposed branch: lp://qastaging/~unity-2d-team/unity-2d/hud-redesign
Merge into: lp://qastaging/unity-2d
Diff against target: 432 lines (+250/-30)
7 files modified
shell/HudLoader.qml (+8/-2)
shell/Shell.qml (+3/-3)
shell/hud/Hud.qml (+36/-21)
shell/launcher/Launcher.qml (+3/-1)
shell/launcher/LauncherItem.qml (+9/-3)
tests/hud/hud_show_hide_tests.rb (+8/-0)
tests/hud/hud_show_hide_tests_hide-mode0.rb (+183/-0)
To merge this branch: bzr merge lp://qastaging/~unity-2d-team/unity-2d/hud-redesign
Reviewer Review Type Date Requested Status
Andrea Cimitan (community) desing Approve
Albert Astals Cid (community) Approve
Review via email: mp+100096@code.qastaging.launchpad.net

Commit message

[hud] Redesign for hide-mode=0 case. Launcher's BFB icon replaced with one specified by HUD.

BFB icon animation left for later commit.

Description of the change

[hud] Redesign for hide-mode=0 case. Launcher's BFB icon replaced with one specified by HUD.

BFB icon animation left for later commit.

To post a comment you must log in.
Revision history for this message
Albert Astals Cid (aacid) wrote :

Tests are missing

There is a behaviour change, previous if:
 * Focus firefox
 * Show hud
 * Type some of the firefox menu items
 * Press down arrow
 * Firefox icon shown
But if you do this with this code i get the "unknown icon"

Revision history for this message
Albert Astals Cid (aacid) wrote :

One more thing: Is it the left pip you have to enable when opening the hud? With the dash we enable the right one

Revision history for this message
Albert Astals Cid (aacid) wrote :

Set as need fixing as per previous comments

review: Needs Fixing
Revision history for this message
Albert Astals Cid (aacid) wrote :

You can see the new looks on the attachments at https://bugs.launchpad.net/unity-2d/+bug/948960
Launcher Always visible https://bugs.launchpad.net/unity-2d/+bug/948960/+attachment/2987713/+files/hidemode0.png
Launcher Autohide https://bugs.launchpad.net/unity-2d/+bug/948960/+attachment/2987713/+files/hidemode0.png

Revision history for this message
Albert Astals Cid (aacid) wrote :

Autohide is https://launchpadlibrarian.net/99612519/hidemode1.png

Revision history for this message
Albert Astals Cid (aacid) wrote :

Looks good from a code POV, needs design approval

review: Approve
Revision history for this message
Andrea Cimitan (cimi) wrote :

I think design is definitely an improvement.
In case we will notice something that requires tweak we will file new bugs for them.

review: Approve (desing)
Revision history for this message
Albert Astals Cid (aacid) wrote :

UIFe approved at https://bugs.launchpad.net/ubuntu/+source/unity-2d/+bug/971603

Revision history for this message
Unity Merger (unity-merger) wrote :

No commit message specified.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches