Merge lp://qastaging/~unity-2d-team/unity-2d/real-transparency into lp://qastaging/unity-2d/3.0
| Status: | Merged |
|---|---|
| Merged at revision: | 586 |
| Proposed branch: | lp://qastaging/~unity-2d-team/unity-2d/real-transparency |
| Merge into: | lp://qastaging/unity-2d/3.0 |
| Diff against target: |
647 lines (+174/-240) 17 files modified
debian/libunity-2d-private0.install (+1/-0) launcher/Launcher.qml (+18/-2) launcher/app/launcher.cpp (+1/-4) launcher/app/launcherview.cpp (+8/-0) libunity-2d-private/Unity2d/CMakeLists.txt (+3/-1) libunity-2d-private/Unity2d/GnomeBackground.qml (+113/-0) libunity-2d-private/Unity2d/qmldir (+2/-0) libunity-2d-private/Unity2d/screeninfo.cpp (+5/-0) libunity-2d-private/Unity2d/screeninfo.h (+4/-0) libunity-2d-private/src/unity2dpanel.cpp (+8/-2) libunity-2d-private/src/unity2dpanel.h (+1/-1) places/GnomeBackground.qml (+0/-107) places/app/dashdeclarativeview.cpp (+0/-6) places/app/dashdeclarativeview.h (+0/-3) places/dash.qml (+6/-5) spread/GnomeBackground.qml (+0/-109) spread/Workspace.qml (+4/-0) |
| To merge this branch: | bzr merge lp://qastaging/~unity-2d-team/unity-2d/real-transparency |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Florian Boucault (community) | Approve | ||
|
Review via email:
|
|||
Commit message
[dash][launcher] Implement real transparency when there's a compositor running.
Description of the change
This branch implements real transparency in the launcher and dash when a compositing manager is active.
The opacity of the transparency may be off and need to be double checked.
Please also note that I put in some fixes in the GnomeBackground QML class, which now is not tied anymore to a specific view (it is still copied in two places, but it's easier to merge into a plugin when we decide to do that).
There's also a fix for performance, so that the fake background is only loaded when the compositor is not running.
Finally, please note that the bug regarding slideshow backgrounds (703574) is fixed by this patch only when compositing mode is running. The fake transparency code still has the issue.
I suppose it can be fixed in the fake transparency case by taking the screenshot of the Nautilus desktop window, but then it would need to look for damage events on that window and update, and I didn't have time to implement that solution yet.
| Ugo Riboni (uriboni) wrote | # |
The panel exhibits visual artifacts. See http://