Snappy Scope

Merge lp://qastaging/~unity-api-team/unity-scope-snappy/add_gettext_to_vendors into lp://qastaging/~unity-api-team/unity-scope-snappy/trunk

  1. add_gettext_to_vendors
  2. Merge into trunk
Proposed by Antti Kaijanmäki
Status: Needs review
Proposed branch: lp://qastaging/~unity-api-team/unity-scope-snappy/add_gettext_to_vendors
Merge into: lp://qastaging/~unity-api-team/unity-scope-snappy/trunk
Diff against target: 579 lines (+473/-10)
6 files modified
debian/copyright (+4/-0)
internal/github.com/gosexy/gettext/LICENSE (+20/-0)
internal/github.com/gosexy/gettext/README.md (+94/-0)
internal/github.com/gosexy/gettext/gettext.go (+207/-0)
internal/github.com/gosexy/gettext/gettext_test.go (+130/-0)
internal/vendor.json (+18/-10)
To merge this branch: bzr merge lp://qastaging/~unity-api-team/unity-scope-snappy/add_gettext_to_vendors
Reviewer Review Type Date Requested Status
Kyle Fazzari (community) Needs Fixing
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+269290@code.qastaging.launchpad.net

Commit message

Add github.com/gosexy/gettext to vendors.

Description of the change

-

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:34
http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-ci/143/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-amd64-ci/100/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-armhf-ci/97/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-i386-ci/97/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-snappy-ci/143/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Kyle Fazzari (kyrofa) wrote :

Add this to debian/copyright, as well. Another comment is in the diff.

review: Needs Fixing
Reply
lp://qastaging/~unity-api-team/unity-scope-snappy/add_gettext_to_vendors updated
35. By Antti Kaijanmäki

merge trunk, resolve conflict in internal/vendor.json

Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

OK, will modify debian/copyright.

Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:35
http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-ci/147/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-amd64-ci/104
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-armhf-ci/101
        deb: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-armhf-ci/101/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-i386-ci/101

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-snappy-ci/147/rebuild

review: Approve (continuous-integration)
Reply
lp://qastaging/~unity-api-team/unity-scope-snappy/add_gettext_to_vendors updated
36. By Antti Kaijanmäki

update debian/copyright

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:36
http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-ci/151/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-amd64-ci/108
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-armhf-ci/105
        deb: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-armhf-ci/105/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-i386-ci/105

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-snappy-ci/151/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Kyle Fazzari (kyrofa) wrote :

A few more things that might need fixing here.

review: Needs Fixing
Reply

Unmerged revisions

36. By Antti Kaijanmäki

update debian/copyright

35. By Antti Kaijanmäki

merge trunk, resolve conflict in internal/vendor.json

34. By Antti Kaijanmäki

Add github.com/gosexy/gettext to vendors.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches