Snappy Scope

Merge lp://qastaging/~unity-api-team/unity-scope-snappy/setup_translations into lp://qastaging/~unity-api-team/unity-scope-snappy/trunk

setup_translations
Merge into trunk

Proposed by Antti Kaijanmäki on 2015-08-27

Status:	Needs review
Proposed branch:	lp://qastaging/~unity-api-team/unity-scope-snappy/setup_translations
Merge into:	lp://qastaging/~unity-api-team/unity-scope-snappy/trunk
Prerequisite:	lp://qastaging/~unity-api-team/unity-scope-snappy/add_gettext_to_vendors
Diff against target:	236 lines (+134/-0) 12 files modified .bzrignore (+2/-0) Makefile (+1/-0) README.dev (+7/-0) debian/control (+2/-0) debian/rules (+2/-0) debian/unity-scope-snappy.install (+1/-0) po/Makefile (+14/-0) po/fi_FI.UTF-8.po (+23/-0) po/sv_SV.UTF-8.po (+22/-0) po/unity-scope-snappy.pot (+21/-0) po/update-unity-scopes-snappy-pot.sh (+32/-0) store/main.go (+7/-0)
To merge this branch:	bzr merge lp://qastaging/~unity-api-team/unity-scope-snappy/setup_translations
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Kyle Fazzari (community)		2015-08-27	Needs Fixing on 2015-11-19
PS Jenkins bot (community)	continuous-integration		Approve on 2015-08-27
Review via email: mp+269292@code.qastaging.launchpad.net

Commit message

Set up gettext translations in the tree and packaging.

Description of the change

end results:

http://pastebin.ubuntu.com/12203143/

Revision history for this message

Antti Kaijanmäki (kaijanmaki) wrote on 2015-08-27:

the dummy string and translations will be removed by the next MP which will have the proper strings marked for translation.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-08-27:

FAILED: Continuous integration, rev:45
http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-ci/142/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-amd64-ci/99/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-armhf-ci/96/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-i386-ci/96/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-snappy-ci/142/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~unity-api-team/unity-scope-snappy/setup_translations updated on 2015-08-27

46. By Antti Kaijanmäki on 2015-08-27: merge trunk.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-08-27:

PASSED: Continuous integration, rev:46
http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-ci/146/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-amd64-ci/103
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-armhf-ci/100
        deb: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-armhf-ci/100/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-i386-ci/100

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-snappy-ci/146/rebuild

review: Approve (continuous-integration)

lp://qastaging/~unity-api-team/unity-scope-snappy/setup_translations updated on 2015-08-27

47. By Antti Kaijanmäki on 2015-08-27: merge prerequisite

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-08-27:

PASSED: Continuous integration, rev:47
http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-ci/150/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-amd64-ci/107
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-armhf-ci/104
        deb: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-armhf-ci/104/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-snappy-wily-i386-ci/104

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-snappy-ci/150/rebuild

review: Approve (continuous-integration)

Revision history for this message

Kyle Fazzari (kyrofa) wrote on 2015-11-19:

The `make install` command shouldn't be repurposed here. I can understand the misunderstanding since golang does things a little strangely, but `make install` simply runs `go install` for a few packages, which simply places things in $GOPATH/bin. This rule is simply a convenience function to save some typing, and isn't actually used by the debian/rules, which means your .mo injection doesn't actually result in .mo files being placed in the .deb. Not only that, but your injection breaks the convenience function by requiring the undocumented definition of $BUILDDIR.

Instead of using the install rule, let's add a convenience Makefile rule for generating the .mo files, and place the generated files somewhere in the codebase (even leaving them in po/ is fine, or take a PREFIX or something), and call it from debian/rules. Then place it using the debian .install file.

A few other comments are inline.

review: Needs Fixing