Merge into plugins-main-trunk : plugins-main-trunk.fixes-2011-03-04 : Code : Compiz

Status:	Merged
Merged at revision:	4
Proposed branch:	lp://qastaging/~unity-team/compiz/plugins-main-trunk.fixes-2011-03-04
Merge into:	lp://qastaging/~unity-team/compiz/plugins-main-trunk
Diff against target:	53 lines (+22/-2) 2 files modified expo/expo.xml.in (+12/-0) expo/src/expo.cpp (+10/-2)
To merge this branch:	bzr merge lp://qastaging/~unity-team/compiz/plugins-main-trunk.fixes-2011-03-04
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Didier Roche-Tolomelli		2011-04-08	Approve on 2011-04-08
Review via email: mp+56919@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2011-04-08.

Allows expo to match the visual design better

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2011-04-08: Posted in a previous version of this proposal

#

The diff has conflicts, did you propose to the right branch?

review: Needs Fixing

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2011-04-08: Posted in a previous version of this proposal

#

You're right, somehow it ended up on lp:compiz again :/

On Fri, Apr 8, 2011 at 4:22 PM, Didier Roche <email address hidden> wrote:
> Review: Needs Fixing
> The diff has conflicts, did you propose to the right branch?
>
> It seems an UI change, that will be nice that you do the paper work here: https://wiki.ubuntu.com/FreezeExceptionProcess#UserInterfaceFreeze%20Exceptions
> --
> https://code.launchpad.net/~unity-team/compiz/plugins-main-trunk.fixes-2011-03-04/+merge/56892
> Your team Unity Team is subscribed to branch lp:~unity-team/compiz/trunk.
>

--
Sam Spilsbury

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2011-04-08: Posted in a previous version of this proposal

#

You're right, somehow it ended up on lp:compiz again :/

On Fri, Apr 8, 2011 at 4:22 PM, Didier Roche <email address hidden> wrote:
> Review: Needs Fixing
> The diff has conflicts, did you propose to the right branch?
>
> It seems an UI change, that will be nice that you do the paper work here: https://wiki.ubuntu.com/FreezeExceptionProcess#UserInterfaceFreeze%20Exceptions
> --
> https://code.launchpad.net/~unity-team/compiz/plugins-main-trunk.fixes-2011-03-04/+merge/56892
> Your team Unity Team is subscribed to branch lp:~unity-team/compiz/trunk.
>

--
Sam Spilsbury

Revision history for this message

David Barth (dbarth) wrote on 2011-04-08:

#

I've re-proposed the patch to the correct branch: lp:~unity-team/compiz/plugins-main-trunk

5. By Sam Spilsbury on 2011-04-08: Much better implementation. Default should be X Offset: 64, Y Offset: 24

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2011-04-08:

#

+1 looks good!

A bug should be opened and treated for the UI freeze.

review: Approve

Compiz