Merge lp://qastaging/~unity-team/compiz/trunk.icccm-4.1.4 into lp://qastaging/~unity-team/compiz/trunk
Proposed by
Sam Spilsbury
| Status: | Merged |
|---|---|
| Merge reported by: | David Barth |
| Merged at revision: | not available |
| Proposed branch: | lp://qastaging/~unity-team/compiz/trunk.icccm-4.1.4 |
| Merge into: | lp://qastaging/~unity-team/compiz/trunk |
| Diff against target: |
74 lines (+23/-13) 2 files modified
CMakeLists.txt (+1/-1) src/window.cpp (+22/-12) |
| To merge this branch: | bzr merge lp://qastaging/~unity-team/compiz/trunk.icccm-4.1.4 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Loïc Molinari (community) | Approve | ||
| David Barth (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
ICCCM Compliance. We need to handle the case where the window maps to get from Withdrawn state to Iconic state such that it is managed but never actually mapped. This is crack, but applications do it, so we have to support it (key perpetrator, xterm -iconic)
To post a comment you must log in.
Revision history for this message
| David Barth (dbarth) wrote | # |
Revision history for this message
| David Barth (dbarth) | # |
review:
Approve
Revision history for this message
| Loïc Molinari (loic.molinari) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Same here: can you provide 2 test cases:
1. to verify that the issue is solved
2. to verify that "normal" cases still work as before
Please copy them to comments in the bug report, as the merge prop history gets lost once the branch is merged.
Thanks