dee

Merge lp://qastaging/~unity-team/dee/changeset-demultiplexer into lp://qastaging/dee

  1. changeset-demultiplexer
  2. Merge into trunk
Proposed by Nick Dedekind
Status: Needs review
Proposed branch: lp://qastaging/~unity-team/dee/changeset-demultiplexer
Merge into: lp://qastaging/dee
Diff against target: 1591 lines (+505/-172)
13 files modified
configure.ac (+3/-3)
debian/libdee-1.0-4.symbols (+6/-0)
src/Makefile.am (+4/-2)
src/dee-changeset-demultiplexer.c (+94/-0)
src/dee-changeset-demultiplexer.h (+97/-0)
src/dee-filter-model.c (+226/-118)
src/dee-filter-model.h (+5/-1)
src/dee-sequence-model.c (+13/-13)
src/dee.h (+1/-0)
tests/Makefile.am (+2/-2)
tests/test-dee.c (+3/-3)
tests/test-filter-model.c (+42/-29)
vapi/dee-1.0.vapi (+9/-1)
To merge this branch: bzr merge lp://qastaging/~unity-team/dee/changeset-demultiplexer
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Unity Team Pending
Review via email: mp+196290@code.qastaging.launchpad.net

Commit message

Demultiplex the changeset rowAdd/Removes when coming into multiple filter models.

Description of the change

Demultiplex the change-set rowAdd/Removes when coming into multiple filter models.

This was causing issues where active change-sets were being queried when the rows didn't exist due to another model being flushed first.

To post a comment you must log in.
lp://qastaging/~unity-team/dee/changeset-demultiplexer updated
433. By Nick Dedekind

updated author

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:433
http://jenkins.qa.ubuntu.com/job/dee-ci/14/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-trusty-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-trusty-armhf-ci/2
        deb: http://jenkins.qa.ubuntu.com/job/dee-trusty-armhf-ci/2/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dee-trusty-i386-ci/2

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dee-ci/14/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Michal Hruby (mhr3) wrote :

I'm not completely sure about this, on one hand it does the job it's supposed to do, on the other it's very specific functionality which is now exposed as a base dee class (on the same level as DeeModel and DeeIndex) and that doesn't feel right.

Reply

Unmerged revisions

433. By Nick Dedekind

updated author

432. By Nick Dedekind

Added changeset demultiplexer for filter models

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: