Merge lp://qastaging/~unity-team/dee/noitcasnart-desrever into lp://qastaging/dee
Proposed by
Mikkel Kamstrup Erlandsen
| Status: | Merged |
|---|---|
| Approved by: | Michal Hruby |
| Approved revision: | 345 |
| Merged at revision: | 343 |
| Proposed branch: | lp://qastaging/~unity-team/dee/noitcasnart-desrever |
| Merge into: | lp://qastaging/dee |
| Diff against target: |
575 lines (+433/-7) 4 files modified
src/dee-transaction.c (+6/-5) tests/model-helper-clear3add5.c (+22/-0) tests/test-model-interactions.c (+75/-0) tests/test-transaction.c (+330/-2) |
| To merge this branch: | bzr merge lp://qastaging/~unity-team/dee/noitcasnart-desrever |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michal Hruby (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Make DeeTransaction insert rows in an appending manner (instead of prepending) during commit(). Several places in Unity subtly assume an appending behavior on everything. This, among others, caused results from lenses to be reversed when using a DeeTransaction.
Most of the noise in this diff is me adding tonnes of test case left and right to track this down. The real meat is in the last revision.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Who wouldn't approve 500 lines of extra tests?! ;)