Merge lp://qastaging/~unity-team/music-app/infographics-translations into lp://qastaging/music-app/remix
Status: | Needs review |
---|---|
Proposed branch: | lp://qastaging/~unity-team/music-app/infographics-translations |
Merge into: | lp://qastaging/music-app/remix |
Diff against target: |
3589 lines (+609/-565) 69 files modified
music-app.qml (+2/-2) po/CMakeLists.txt (+1/-0) po/am.po (+2/-2) po/ar.po (+2/-2) po/ast.po (+42/-38) po/az.po (+1/-1) po/be.po (+2/-2) po/bg.po (+2/-2) po/bn.po (+1/-1) po/br.po (+2/-2) po/ca.po (+2/-2) po/ca@valencia.po (+43/-40) po/ckb.po (+1/-1) po/com.ubuntu.music.pot (+36/-36) po/cs.po (+2/-2) po/da.po (+2/-2) po/de.po (+42/-38) po/el.po (+42/-38) po/en_AU.po (+2/-2) po/en_GB.po (+2/-2) po/eo.po (+1/-1) po/es.po (+2/-2) po/eu.po (+2/-2) po/fa.po (+46/-42) po/fi.po (+2/-2) po/fo.po (+1/-1) po/fr.po (+2/-2) po/gd.po (+44/-40) po/gl.po (+2/-2) po/he.po (+2/-2) po/hr.po (+1/-1) po/hu.po (+2/-2) po/id.po (+2/-2) po/is.po (+2/-2) po/it.po (+2/-2) po/ja.po (+2/-2) po/km.po (+2/-2) po/kn.po (+1/-1) po/ko.po (+2/-2) po/lv.po (+1/-1) po/mi.po (+1/-1) po/ml.po (+1/-1) po/mr.po (+1/-1) po/ms.po (+2/-2) po/my.po (+2/-2) po/nb.po (+2/-2) po/nl.po (+2/-2) po/pa.po (+47/-45) po/pl.po (+2/-2) po/ps.po (+1/-1) po/pt.po (+42/-38) po/pt_BR.po (+2/-2) po/ro.po (+44/-40) po/ru.po (+2/-2) po/shn.po (+1/-1) po/si.po (+1/-1) po/sl.po (+1/-1) po/sq.po (+1/-1) po/sr.po (+2/-2) po/st.po (+1/-1) po/sv.po (+2/-2) po/ta.po (+1/-1) po/te.po (+1/-1) po/tr.po (+42/-38) po/ug.po (+2/-2) po/uk.po (+2/-2) po/zh_CN.po (+45/-39) po/zh_HK.po (+2/-2) po/zh_TW.po (+2/-2) |
To merge this branch: | bzr merge lp://qastaging/~unity-team/music-app/infographics-translations |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrew Hayzen | Needs Fixing | ||
Victor Thompson | Needs Fixing | ||
David Planella | Pending | ||
Review via email: mp+248251@code.qastaging.launchpad.net |
This proposal supersedes a proposal from 2015-01-29.
Commit message
Strings sent to infographics are no-longer translated - just extract them to translation catalogue
Description of the change
Strings sent to infographics are no-longer translated - just extract them to translation catalogue
Music app currently does:
"<b>%1</b> " + i18n.tr("songs played today")
this has to be changed to:
i18n.noop("Songs played today: <b>%1</b>")
so that the string that is sent to the infographics server is untranslated, and also so that the message catalogue contains the full string "Songs played today: <b>%1</b>"
Note that this MR is dependent on the addition of the "noop" function to i18n. See bug #1417031.
Unmerged revisions
- 831. By Pete Woods
-
Merge trunk
- 830. By Pete Woods
-
Switch to tag function as actually released in the SDK
- 829. By Pete Woods
-
Merge trunk
- 828. By Pete Woods
-
Update translations with new infographics format string
- 827. By Pete Woods
-
Use i18n.noop function
1 inline comment: Is there a reason for changing the format here?
If someone else can get around to testing this, that'd be great. Otherwise, I can do so tonight.