Nux

Merge lp://qastaging/~unity-team/nux/nux.composition-char into lp://qastaging/nux/2.0

  1. nux.composition-char
  2. Merge into 2.0
Proposed by Jay Taoko
Status: Merged
Approved by: Neil J. Patel
Approved revision: 589
Merged at revision: 588
Proposed branch: lp://qastaging/~unity-team/nux/nux.composition-char
Merge into: lp://qastaging/nux/2.0
Diff against target: 716 lines (+559/-11)
10 files modified
Nux/Makefile.am (+4/-2)
Nux/ProgramFramework/TestTextEntry.cpp (+175/-0)
Nux/ProgramFramework/TestTextEntry.h (+79/-0)
Nux/TextEntry.cpp (+9/-0)
Nux/TextEntry.h (+22/-6)
configure.ac (+1/-1)
tests/Makefile.am (+12/-2)
tests/Readme.txt (+3/-0)
tests/gtest-nux-textentry.cpp (+95/-0)
tests/xtest-text-entry-logic.cpp (+159/-0)
To merge this branch: bzr merge lp://qastaging/~unity-team/nux/nux.composition-char
Reviewer Review Type Date Requested Status
Neil J. Patel (community) Approve
Tim Penhey (community) Needs Fixing
Review via email: mp+95652@code.qastaging.launchpad.net

Description of the change

UNBLOCK

* Switch the TextEntry to text input mode (TextEntry::text_input_mode_) following the operation TexTEntry::SetText, TexTEntry::EnterText, TexTEntry::DeleteText. TextEntry::text_input_mode_ is also set to true when a key is pressed in the TextEntry.

Fix bug #944674

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

Jay, can you change the description to explain what the problem was and how this branch fixes it?

Also, tests :-)

review: Needs Fixing
lp://qastaging/~unity-team/nux/nux.composition-char updated
589. By Jay Taoko

* Test the TextEntry::text_input_mode_ is different context.
* TextEntry::EnterText and TextEntry::DeleteText have been made public to allow testing.

Revision history for this message
Neil J. Patel (njpatel) wrote :

Looks good, passes all tests, thanks Jay!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: