Merge lp://qastaging/~unity-team/ubuntu-settings-components/suru-theme into lp://qastaging/~registry/ubuntu-settings-components/trunk

Proposed by Michał Sawicz
Status: Merged
Approved by: Nick Dedekind
Approved revision: 79
Merged at revision: 69
Proposed branch: lp://qastaging/~unity-team/ubuntu-settings-components/suru-theme
Merge into: lp://qastaging/~registry/ubuntu-settings-components/trunk
Diff against target: 301 lines (+122/-24)
9 files modified
SettingsComponents.qml (+16/-0)
Ubuntu/Settings/Menus/AccessPointMenu.qml (+2/-4)
Ubuntu/Settings/Menus/EventMenu.qml (+2/-1)
Ubuntu/Settings/Menus/SliderMenu.qml (+19/-11)
Ubuntu/Settings/Menus/StandardMenu.qml (+66/-0)
Ubuntu/Settings/Menus/qmldir (+1/-0)
debian/changelog (+6/-0)
debian/control (+5/-3)
tests/qmltests/Menus/tst_SliderMenu.qml (+5/-5)
To merge this branch: bzr merge lp://qastaging/~unity-team/ubuntu-settings-components/suru-theme
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Nick Dedekind (community) Approve
Michał Sawicz (community) Approve
Ubuntu Unity PS integration team Pending
Review via email: mp+220739@code.qastaging.launchpad.net

Commit message

Adapt to suru theme

To post a comment you must log in.
Revision history for this message
Michał Sawicz (saviq) wrote :

 * Are there any related MPs required for this MP to build/function as expected? Please list.
https://code.launchpad.net/~saviq/ubuntu-ui-toolkit/suru-switch/+merge/220734

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Yes.

 * If you changed the UI, has there been a design review?
There will be.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

See inline.

Also, think StandardMenu *could* have rightLabel? It would help with one issue in settings.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

See inline.

review: Needs Fixing
Revision history for this message
Michał Sawicz (saviq) wrote :

Yes.

review: Approve
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

LGTM

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: