Merge lp://qastaging/~unity-team/unity-lens-music/improved-search-results-5.0 into lp://qastaging/unity-lens-music/5.0

Proposed by Mikkel Kamstrup Erlandsen
Status: Merged
Approved by: Michal Hruby
Approved revision: 83
Merged at revision: 83
Proposed branch: lp://qastaging/~unity-team/unity-lens-music/improved-search-results-5.0
Merge into: lp://qastaging/unity-lens-music/5.0
Diff against target: 102 lines (+50/-25)
1 file modified
src/musicstore-collection.vala (+50/-25)
To merge this branch: bzr merge lp://qastaging/~unity-team/unity-lens-music/improved-search-results-5.0
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Review via email: mp+114349@code.qastaging.launchpad.net

Commit message

Fix u1 search results to not seem too random. Lowers mem churn in musicstore scope quite a bit.

Description of the change

Backport from trunk: Fix u1 search results to not seem too random. Lowers mem churn in musicstore scope quite a bit.

This was rooted in the fact that musicsearch.ubuntu.com returns a mix of artists, albums, and tracks in the results. We do not show artists, so if the results contains mainly that, then we're screwed (even though there could be many potential track/album matches outside the fetched results). Luckily newer versions of the webservice contains some parameters to tweak this behaviour. This commit makes us use that.

In addition to using the new musicsearch API I also lowered memory churn quite considerably by removing the need to create a lot of Track/Album objects and do excessive string copying.

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

Looking good. LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: