Merge lp://qastaging/~unity-team/unity/dash-fixes-2011-02-24 into lp://qastaging/unity

Proposed by Neil J. Patel
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: no longer in the source branch.
Merged at revision: 882
Proposed branch: lp://qastaging/~unity-team/unity/dash-fixes-2011-02-24
Merge into: lp://qastaging/unity
Diff against target: 2020 lines (+784/-345)
35 files modified
CMakeLists.txt (+1/-1)
com.canonical.Unity.gschema.xml (+14/-1)
src/IconTexture.cpp (+62/-34)
src/IconTexture.h (+6/-1)
src/LauncherIcon.cpp (+1/-0)
src/PanelIndicatorObjectView.cpp (+4/-4)
src/PanelMenuView.cpp (+15/-13)
src/PanelTray.cpp (+4/-5)
src/PlaceFactoryFile.cpp (+8/-7)
src/PlacesController.cpp (+38/-4)
src/PlacesController.h (+2/-0)
src/PlacesGroup.cpp (+18/-15)
src/PlacesGroup.h (+5/-5)
src/PlacesHomeView.cpp (+244/-97)
src/PlacesHomeView.h (+14/-5)
src/PlacesResultsController.cpp (+16/-16)
src/PlacesResultsView.cpp (+0/-18)
src/PlacesResultsView.h (+0/-3)
src/PlacesSearchBar.cpp (+14/-9)
src/PlacesSearchBar.h (+1/-1)
src/PlacesSettings.cpp (+93/-0)
src/PlacesSettings.h (+58/-0)
src/PlacesSimpleTile.cpp (+12/-6)
src/PlacesTile.cpp (+9/-8)
src/PlacesView.cpp (+27/-25)
src/QuicklistMenuItemCheckmark.cpp (+4/-0)
src/QuicklistMenuItemLabel.cpp (+2/-0)
src/QuicklistMenuItemRadio.cpp (+4/-0)
src/QuicklistMenuItemSeparator.cpp (+1/-0)
src/StaticCairoText.cpp (+10/-7)
src/TimeMe.cpp (+22/-0)
src/TimeMe.h (+43/-0)
src/Tooltip.cpp (+1/-1)
src/unitya11y.cpp (+3/-0)
tests/CMakeLists.txt (+28/-59)
To merge this branch: bzr merge lp://qastaging/~unity-team/unity/dash-fixes-2011-02-24
Reviewer Review Type Date Requested Status
Unity Team Pending
Review via email: mp+50896@code.qastaging.launchpad.net

Description of the change

All the attached bugs plus various clean ups of the code.

You'll need latest Nux trunk and export UNITY_A11Y_DISABLE=1 otherwise unity won't run because of missing schemas. Oh, speaking of schemas, I install some more options so make sure your installing the gsettings stuff in the right place, ping me if you get stuck!

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

CreateShortcutFromExec (markup, _("Browse the Web"), "firefox");
and such…
-> as far as I understand, "firefox", "evolution", "banshee" are just the icon named that we ship to show it. As the branch make some detection of the prefer tool, we can maybe ship as well "generic icons" for those cases (and rename firefox in browser-icon, evolution in mail-icon, banshee in mediaplayer-icon and such)?
I know there is the issue to detect which Exec corresponds to which desktop file, that can wait :)

Currently building and testing

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

approved! nice enhancements :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.