Merge lp://qastaging/~unity-team/unity/dash-fixes-2011-03-07 into lp://qastaging/unity

Proposed by Neil J. Patel
Status: Merged
Approved by: Gord Allott
Approved revision: no longer in the source branch.
Merged at revision: 920
Proposed branch: lp://qastaging/~unity-team/unity/dash-fixes-2011-03-07
Merge into: lp://qastaging/unity
Diff against target: 842 lines (+254/-140)
19 files modified
src/PanelHomeButton.cpp (+14/-0)
src/PanelHomeButton.h (+3/-4)
src/PanelMenuView.cpp (+10/-3)
src/PanelMenuView.h (+3/-0)
src/PanelView.h (+5/-5)
src/PlaceEntry.h (+3/-0)
src/PlaceEntryHome.cpp (+33/-0)
src/PlaceEntryHome.h (+7/-1)
src/PlaceEntryRemote.cpp (+50/-0)
src/PlaceEntryRemote.h (+3/-0)
src/PlacesGroup.cpp (+4/-39)
src/PlacesGroup.h (+0/-3)
src/PlacesGroupController.cpp (+90/-51)
src/PlacesGroupController.h (+7/-4)
src/PlacesResultsController.cpp (+4/-4)
src/PlacesResultsController.h (+3/-3)
src/PlacesSearchBar.cpp (+4/-9)
src/PlacesSearchBar.h (+1/-2)
src/PlacesView.cpp (+10/-12)
To merge this branch: bzr merge lp://qastaging/~unity-team/unity/dash-fixes-2011-03-07
Reviewer Review Type Date Requested Status
Gord Allott (community) Approve
Review via email: mp+52415@code.qastaging.launchpad.net

Description of the change

Linked bugs and also changes the way we do group expanding to just add/remove the tiles, which saves a lot of headache for keynav (and is a big performance gain)

When we expand->unexpand->expand, the order gets messed up a bit, but I'll fix that for thurs.

To post a comment you must log in.
Revision history for this message
Gord Allott (gordallott) wrote :

Approved although i seem to be missing "files.png" and "applications.png" in /usr/share/unity/

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

the images warning is bug #727672

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.