Merge lp://qastaging/~unity-team/unity/results-view-fixes into lp://qastaging/unity
Proposed by
Neil J. Patel
| Status: | Merged | ||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Merged at revision: | 470 | ||||||||||||||||||||||||||||||||||||
| Proposed branch: | lp://qastaging/~unity-team/unity/results-view-fixes | ||||||||||||||||||||||||||||||||||||
| Merge into: | lp://qastaging/unity | ||||||||||||||||||||||||||||||||||||
| Diff against target: | 0 lines | ||||||||||||||||||||||||||||||||||||
| To merge this branch: | bzr merge lp://qastaging/~unity-team/unity/results-view-fixes | ||||||||||||||||||||||||||||||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jason Smith (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
There are the linked bugs as well as lot's of other small things. Please just play around and see if there are any regressions. It should feel better than before, however the main things, visually, remaining are:
- Home screen no-results view. This hasn't been spec'ed (afaict) or visualized
- Re-using tiles, as I'm still getting mass row-removed before mass row-added signals. i need to cache the removed and try and do the smallest shift as possible
Where there has been no or minimal design, I've tried to stick with what we do have and guess the rest. It's all tested on 1024x600.
To post a comment you must log in.
+1, looks nice code doesn't seem to have any obvious deficiencies