Merge lp://qastaging/~unity-team/unity/unity.fix-741154 into lp://qastaging/unity

Proposed by Mirco Müller
Status: Merged
Merged at revision: 1053
Proposed branch: lp://qastaging/~unity-team/unity/unity.fix-741154
Merge into: lp://qastaging/unity
Diff against target: 91 lines (+21/-0)
2 files modified
src/Launcher.cpp (+11/-0)
src/QuicklistView.cpp (+10/-0)
To merge this branch: bzr merge lp://qastaging/~unity-team/unity/unity.fix-741154
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+55564@code.qastaging.launchpad.net

Description of the change

Add support for launcher/quicklist keyboard-navigation to also react on cursor-keys of numeric keypad. Fixes LP: #741154

Since it is not clear, if adding the needed defines for the num. keypad cursor-keys to nux breaks ABI, I've added them locally to Launcher.cpp and QuicklistView.cpp as a temp. workaround.

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

 review approve

Looks good. You may want to consider adding a #ifndef guard around the
NUX_KP _* defines to not break the build of Unity releases on newer
versions of Nux?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.