Merge lp://qastaging/~unity-team/unity/unity.fix-750374 into lp://qastaging/unity

Proposed by Mirco Müller
Status: Merged
Approved by: Gord Allott
Approved revision: no longer in the source branch.
Merged at revision: 1122
Proposed branch: lp://qastaging/~unity-team/unity/unity.fix-750374
Merge into: lp://qastaging/unity
Diff against target: 406 lines (+21/-288)
2 files modified
src/PlacesVScrollBar.cpp (+19/-248)
src/PlacesVScrollBar.h (+2/-40)
To merge this branch: bzr merge lp://qastaging/~unity-team/unity/unity.fix-750374
Reviewer Review Type Date Requested Status
Gord Allott (community) Approve
David Barth (community) Approve
Review via email: mp+57359@code.qastaging.launchpad.net

Description of the change

Adapt to late design-change. Remove state-handling for vertical Dash-scrollbar. Change rendering of said scrollbar. Fixes LP: #750374

To post a comment you must log in.
Revision history for this message
David Barth (dbarth) wrote :

line 319: is the returned value always defined? the next line relies on that assumption.

review: Needs Information
Revision history for this message
Mirco Müller (macslow) wrote :

Added additional checks to protect against potential segfaults.

Revision history for this message
David Barth (dbarth) wrote :

LTGM

review: Approve
Revision history for this message
Gord Allott (gordallott) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.