Merge lp://qastaging/~unity-team/unity/unity.fix-757588 into lp://qastaging/unity
Proposed by
Mirco Müller
| Status: | Merged |
|---|---|
| Approved by: | Mirco Müller |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 1121 |
| Proposed branch: | lp://qastaging/~unity-team/unity/unity.fix-757588 |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
461 lines (+148/-70) 14 files modified
src/Launcher.cpp (+35/-20) src/Launcher.h (+2/-0) src/PanelHomeButton.cpp (+9/-6) src/PanelMenuView.cpp (+9/-3) src/PlacesController.cpp (+19/-7) src/PlacesController.h (+2/-0) src/PlacesHomeView.cpp (+9/-3) src/PlacesHomeView.h (+2/-0) src/PlacesSearchBar.cpp (+9/-4) src/PlacesSearchBar.h (+2/-0) src/PlacesView.cpp (+22/-12) src/PlacesView.h (+2/-0) src/unityshell.cpp (+24/-14) src/unityshell.h (+2/-1) |
| To merge this branch: | bzr merge lp://qastaging/~unity-team/unity/unity.fix-757588 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mikkel Kamstrup Erlandsen (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Correctly unregister all registered interests with the ubus-server in a class' destructor.
To post a comment you must log in.
Revision history for this message
| Mikkel Kamstrup Erlandsen (kamstrup) wrote | # |
review:
Needs Information
Revision history for this message
| Mirco Müller (macslow) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Great work. Can you maybe use the G_N_ELEMENTS(array) macro instead of the *_MAX_UBUS_HANDLES constants? That would make the code slightly more robust.