Merge lp://qastaging/~unity-team/unity/unity.fix-901164 into lp://qastaging/unity

Proposed by Mirco Müller
Status: Merged
Approved by: Mirco Müller
Approved revision: no longer in the source branch.
Merged at revision: 2225
Proposed branch: lp://qastaging/~unity-team/unity/unity.fix-901164
Merge into: lp://qastaging/unity
Diff against target: 420 lines (+157/-98)
5 files modified
plugins/unityshell/src/LensView.cpp (+7/-0)
plugins/unityshell/src/ResultRendererHorizontalTile.cpp (+147/-95)
plugins/unityshell/src/ResultRendererHorizontalTile.h (+2/-0)
plugins/unityshell/src/ResultRendererTile.cpp (+0/-3)
plugins/unityshell/src/ResultRendererTile.h (+1/-0)
To merge this branch: bzr merge lp://qastaging/~unity-team/unity/unity.fix-901164
Reviewer Review Type Date Requested Status
Andrea Cimitan (community) design Approve
Review via email: mp+100656@code.qastaging.launchpad.net

Commit message

Implement new card view design

Description of the change

Update the horizontal tile renderer (aka "Card View") to comply with the visual specs from Design. This is what it looked like before...

  http://people.canonical.com/~mmueller/before-901164-1.png

... and this is with the fixes from this proposed branch...

  http://people.canonical.com/~mmueller/after-901164-2.png

To post a comment you must log in.
Revision history for this message
Andrea Cimitan (cimi) wrote :

Reference mockups? /me thinks it looks better before :D

Revision history for this message
Andrea Cimitan (cimi) wrote :

Reference mockups:
https://launchpadlibrarian.net/86840462/dash_cardview1.png
https://launchpadlibrarian.net/86840469/dash_cardview2.png

Issue in spacing/padding between items, color (why do they have a color?).

review: Needs Fixing (design)
Revision history for this message
Andrea Cimitan (cimi) wrote :

I can see different opacity used as external line applied to the icons, and a subtle shadow.

Revision history for this message
Andrea Cimitan (cimi) wrote :

(among the other changes)

Revision history for this message
Mirco Müller (macslow) wrote :

You're also not up-to-date as John, who used the same mockups thinking my branch was out of sync with Design. But all the values and visual specs I got are from Rosie and up-to-date.

Revision history for this message
Andrea Cimitan (cimi) wrote :

The mockup is by nature static, while our dash can change its colors and dimensions. We have to be smart and adjust according to our needs.

Refinements I suggested to designers which I got aproval:
1. color behind the cards, two solutions:
  a) pick up either average color and apply a color shade, with reduced alpha.
  b) pick up a tint of black with very slight alpha.
2. padding between cards, two solutions:
  a) apply even padding even on left and right edges of the first and last card, apply evenly.
  b) make cards flexible in width when the dash width is bigger, keeping small padding.

Revision history for this message
Andrea Cimitan (cimi) wrote :

I forgot to say that we will discuss that further with you in IRC.

Revision history for this message
Mirco Müller (macslow) wrote :

I wish those "needs" would be part of the spec in the first place. Until yesterday everything I did was on-spec.

Regarding 1.) I was informed by Rosie, after she checked back with Otto and after I did the merge-proposal, that the non-highlight tint is meant to be like the one on the nav-bar.

Regarding 2.) I also found updated specs (after the merge-proposal) asking for option 2 b).

Revision history for this message
Andrea Cimitan (cimi) wrote :

> I wish those "needs" would be part of the spec in the first place. Until
> yesterday everything I did was on-spec.
>
> Regarding 1.) I was informed by Rosie, after she checked back with Otto and
> after I did the merge-proposal, that the non-highlight tint is meant to be
> like the one on the nav-bar.
>
> Regarding 2.) I also found updated specs (after the merge-proposal) asking for
> option 2 b).

I apologize for the late info. Ideal would be that when the developer is facing issues or different behaviors / conditions with the mockup immediately informs the designer owner of the specs.

Revision history for this message
Mirco Müller (macslow) wrote :

bg-color tinting fix is in http://people.canonical.com/~mmueller/after-901164-3.png

The padding fix comes after this was approved and merged, so there's no conflict with the wide-icon fixes Gord needs to do... and which should be based on this branch being in trunk rather then current trunk.

Revision history for this message
Andrea Cimitan (cimi) wrote :

Approving.
Design is exploring usage of different colors, but this will come after as a separate branch

review: Approve (design)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.