Merge lp://qastaging/~unity-team/unity/unity.hud-signal-956878 into lp://qastaging/unity

Proposed by Jay Taoko
Status: Merged
Approved by: Jay Taoko
Approved revision: no longer in the source branch.
Merged at revision: 2136
Proposed branch: lp://qastaging/~unity-team/unity/unity.hud-signal-956878
Merge into: lp://qastaging/unity
Diff against target: 167 lines (+62/-8)
6 files modified
manual-tests/Hud.txt (+12/-0)
plugins/unityshell/src/HudView.cpp (+6/-2)
plugins/unityshell/src/HudView.h (+1/-0)
tests/autopilot/autopilot/emulators/bamf.py (+8/-2)
tests/autopilot/autopilot/tests/__init__.py (+6/-3)
tests/autopilot/autopilot/tests/test_hud.py (+29/-1)
To merge this branch: bzr merge lp://qastaging/~unity-team/unity/unity.hud-signal-956878
Reviewer Review Type Date Requested Status
Gord Allott (community) Approve
Alex Launi (community) Needs Fixing
Review via email: mp+98215@code.qastaging.launchpad.net

Commit message

* Fix for bug #956878:
The hud is designed such that the first valid option is always selected. When the activated signal is detected early in hud::View::FindKeyFocusArea, the selected button signal is emitted, and the text entry is still selected as the focus area. Therefore, the hud should not reacted to the search_bar_->activated signal since it alreacdy acted in hud::View::FindKeyFocusArea.

Description of the change

* Fix for bug #956878:
The hud is designed such that the first valid option is always selected. When the activated signal is detected early in hud::View::FindKeyFocusArea, the selected button signal is emitted, and the text entry is still selected as the focus area. Therefore, the hud should not reacted to the search_bar_->activated signal since it alreacdy acted in hud::View::FindKeyFocusArea.

To post a comment you must log in.
Revision history for this message
Alex Launi (alexlauni) wrote :

As discussed on IRC, please write an autopilot test for this.

review: Needs Fixing
Revision history for this message
Gord Allott (gordallott) wrote :

+1

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

No commit message specified.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.