Merge lp://qastaging/~unity-team/unity/unity.viewport-bias into lp://qastaging/unity

Proposed by Jason Smith
Status: Merged
Merged at revision: 1632
Proposed branch: lp://qastaging/~unity-team/unity/unity.viewport-bias
Merge into: lp://qastaging/unity
Diff against target: 190 lines (+27/-11)
11 files modified
plugins/unityshell/src/AbstractLauncherIcon.h (+1/-1)
plugins/unityshell/src/BamfLauncherIcon.cpp (+2/-2)
plugins/unityshell/src/BamfLauncherIcon.h (+1/-1)
plugins/unityshell/src/LauncherIcon.h (+1/-1)
plugins/unityshell/src/MockLauncherIcon.h (+1/-1)
plugins/unityshell/src/PluginAdapter.cpp (+8/-2)
plugins/unityshell/src/PluginAdapter.h (+3/-1)
plugins/unityshell/src/WindowManager.cpp (+1/-1)
plugins/unityshell/src/WindowManager.h (+1/-1)
plugins/unityshell/src/unityshell.cpp (+3/-0)
plugins/unityshell/unityshell.xml.in (+5/-0)
To merge this branch: bzr merge lp://qastaging/~unity-team/unity/unity.viewport-bias
Reviewer Review Type Date Requested Status
Sam Spilsbury (community) Needs Fixing
Tim Penhey (community) Approve
Review via email: mp+77088@code.qastaging.launchpad.net

Description of the change

Adds an option to allow alt-tab to bias towards the current viewport rather than globally. Net effect is a behavior much closer to natty alt-tab

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

Seems reasonable on first glance.

review: Approve
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

> result = result << 32;

That doesn't work on some compilers. If you want the high bit you should use << 31

review: Needs Fixing
Revision history for this message
Tim Penhey (thumper) wrote :

Sam, that works fine with G++ on an unsigned long long which is guaranteed to be 64 bit.

Note that this is shift left, not trying to get the high bit.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.