Merge lp://qastaging/~unity-team/unity8/flickables-speed-workaround into lp://qastaging/unity8

Proposed by Andrea Cimitan
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 1243
Merged at revision: 1362
Proposed branch: lp://qastaging/~unity-team/unity8/flickables-speed-workaround
Merge into: lp://qastaging/unity8
Diff against target: 747 lines (+157/-44)
32 files modified
qml/Components/Carousel.qml (+2/-3)
qml/Components/Flickables/Flickable.qml (+23/-0)
qml/Components/Flickables/GridView.qml (+25/-0)
qml/Components/Flickables/ListView.qml (+25/-0)
qml/Components/Flickables/ListViewWithPageHeader.qml (+23/-0)
qml/Components/ResponsiveGridView.qml (+2/-1)
qml/Components/ZoomableImage.qml (+2/-2)
qml/Dash/CardHorizontalList.qml (+2/-1)
qml/Dash/DashContent.qml (+2/-3)
qml/Dash/DashNavigationButton.qml (+2/-1)
qml/Dash/DashNavigationList.qml (+2/-1)
qml/Dash/PageHeader.qml (+2/-1)
qml/Dash/PreviewListView.qml (+2/-3)
qml/Dash/Previews/Preview.qml (+2/-1)
qml/Dash/Previews/PreviewImageGallery.qml (+3/-2)
qml/Dash/ScopeListView.qml (+3/-6)
qml/Dash/ScopeSettingsPage.qml (+2/-1)
qml/Dash/ScopesOverviewAll.qml (+2/-1)
qml/Dash/ScopesOverviewFavorites.qml (+4/-2)
qml/Greeter/LoginList.qml (+2/-2)
qml/Hud/Hud.qml (+2/-1)
qml/Hud/HudParametrizedActionsPage.qml (+2/-1)
qml/Launcher/LauncherPanel.qml (+2/-1)
qml/Notifications/Notification.qml (+2/-1)
qml/Notifications/Notifications.qml (+2/-1)
qml/Panel/IndicatorRow.qml (+2/-1)
qml/Panel/Indicators/DefaultIndicatorPage.qml (+2/-1)
qml/Panel/Indicators/client/IndicatorsList.qml (+2/-1)
qml/Panel/Indicators/client/IndicatorsTree.qml (+2/-1)
qml/Panel/MenuContent.qml (+3/-2)
qml/Stages/PhoneStage.qml (+2/-1)
qml/Stages/TabletStage.qml (+2/-1)
To merge this branch: bzr merge lp://qastaging/~unity-team/unity8/flickables-speed-workaround
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Albert Astals Cid (community) Approve
Review via email: mp+237944@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2014-09-11.

Commit message

Fix flickable speed to be resolution independent, by subclassing components

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
No
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
 * Did you make sure that your branch does not contain spurious tags?
Yes
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
 * If you changed the UI, has there been a design review?
n/a

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

Text conflict in debian/control
Text conflict in plugins/Dash/CardCreator.js
Text conflict in qml/Dash/GenericScopeView.qml
Text conflict in qml/Dash/ScopeSettingsPage.qml
Text conflict in qml/Panel/Indicators/DefaultIndicatorPage.qml
Text conflict in qml/Panel/MenuContent.qml
Text conflict in tests/plugins/Dash/cardcreator/2.res
Text conflict in tests/plugins/Dash/cardcreator/7.res
Text conflict in tests/qmltests/Dash/tst_GenericScopeView.qml
9 conflicts encountered.

review: Needs Fixing
1243. By Andrea Cimitan

Attempt to merge

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

Ok, code looks reasnoable for a workaround and on the phone it feels ok, so if this is the workaround we want, let's go with it.

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass? If not, please explain why.
No, because it's broken in trunk

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches