Unity 8

qml/Components/Orientations.qml (+57/-0)
qml/DeviceConfiguration.qml (+93/-71)
qml/OrientedShell.qml (+35/-25)
qml/Shell.qml (+7/-13)
qml/Stages/DesktopStage.qml (+2/-2)
qml/Stages/PhoneStage.qml (+4/-6)
qml/Stages/SpreadDelegate.qml (+8/-9)
qml/Stages/TabletStage.qml (+13/-7)
tests/qmltests/Stages/tst_PhoneStage.qml (+0/-2)
tests/qmltests/Stages/tst_SpreadDelegate.qml (+6/-2)
tests/qmltests/Stages/tst_TabletStage.qml (+2/-2)
tests/qmltests/tst_OrientedShell.qml (+1/-1)
tests/qmltests/tst_Shell.qml (+2/-2)

To merge this branch:

bzr merge lp://qastaging/~unity-team/unity8/new_fix_upsidedown

Undecided

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Michał Sawicz			Approve on 2015-11-05
PS Jenkins bot (community)	continuous-integration	2015-10-26	Needs Fixing on 2015-10-31
Daniel d'Andrada		2015-10-26	Pending
Review via email: mp+275683@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-10-26.

Commit message

Enable support for overriding application orientations based on device type

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.
No

* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

Branch is intended to supersede lp:~josharenson/unity8/fix_upside_down_apps
by encapsulating the orientation overrides inside a neat QtObject, intended to reduce lines of code and improve clarity.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-26: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6353/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-09-28: Posted in a previous version of this proposal

In tests/qmltests/tst_Shell.qml:

Don't we have to pass an Orientations object to Shell?

I think that's why we're getting the warning and test failures below:

"""
file:///home/dandrader/unity8/new_fix_upsidedown/qml/Stages/SpreadDelegate.qml:159: TypeError: Cannot read property 'primary' of null
"""

"""
FAIL! : qmltestrunner::Shell::test_launchedAppHasActiveFocus(tablet) 'verify()' returned FALSE. ()
Loc: [/home/dandrader/unity8/new_fix_upsidedown/tests/qmltests/tst_Shell.qml(843)]
"""

"""
FAIL! : qmltestrunner::Shell::test_launchedAppKeepsActiveFocusOnUsageModeChange() 'verify()' returned FALSE. ()
Loc: [/home/dandrader/unity8/new_fix_upsidedown/tests/qmltests/tst_Shell.qml(835)]
"""

"""
FAIL! : qmltestrunner::Shell::test_unfocusedAppsAreResumedWhenEnteringWindowedMode() Uncaught exception: Cannot read property 'objectName' of null
   Loc: [/home/dandrader/unity8/new_fix_upsidedown_build/tests/utils/modules/Unity/Test/UnityTestCase.qml(179)]
FAIL! : qmltestrunner::Shell::test_unfocusedAppsGetSuspendedAfterEnteringStagedMode() property requestedState
   Actual (): 1
   Expected (): 2
   Loc: [/home/dandrader/unity8/new_fix_upsidedown/tests/qmltests/tst_Shell.qml(1362)]
"""

review: Needs Fixing

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-09-28: Posted in a previous version of this proposal

In qml/OrientedShell.qml:

"""
orientations: root.orientations ? root.orientations : ""
"""

This looks strange. Passing an empty string in case there's no root.orientations?

In which situation do you expect root.orientations to be null/undefined?

Revision history for this message

Josh Arenson (josharenson) wrote on 2015-09-28: Posted in a previous version of this proposal

> In qml/OrientedShell.qml:
>
> """
> orientations: root.orientations ? root.orientations : ""
> """
>
> This looks strange. Passing an empty string in case there's no
> root.orientations?
>
> In which situation do you expect root.orientations to be null/undefined?

This was residual debug code that I will remove.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-29: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6365/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-29: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6367/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-09-29: Posted in a previous version of this proposal

Some OrientedShell tests are failing and others don't even compile (PhoneStage and TabletStage)!

Please do check the results from the latest jenkins test run

review: Needs Fixing

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-09-29: Posted in a previous version of this proposal

In tests/qmltests/tst_Shell.qml:

"""
orientations: Orientations{ id: orientations }
"""

This id is not being referenced anywhere. Please remove it.

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-01: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6399/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-02: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6402/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Albert Astals Cid (aacid) wrote on 2015-10-08: Posted in a previous version of this proposal

Has wrong branches

Revision history for this message

Josh Arenson (josharenson) wrote on 2015-10-13: Posted in a previous version of this proposal

Stripped tags, merged trunk

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-10-13: Posted in a previous version of this proposal

FAIL! : qmltestrunner::OrientedShell::test_portraitOnlyAppInSideStage(flo) Compared values are not the same
   Actual (): 8
   Expected (): undefined
   Loc: [/home/dandrader/unity8/new_fix_upsidedown/tests/qmltests/tst_OrientedShell.qml(801)]

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-13: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6462/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Josh Arenson (josharenson) wrote on 2015-10-14: Posted in a previous version of this proposal

The solution was already in some code that I must have accidentally removed. qmltestrunner::OrientedShell should pass now. Tags also stripped.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-14: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6463/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-14: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6464/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-10-15: Posted in a previous version of this proposal

whitespace check fails:
qml/Stages/TabletStage.qml: bad whitespace in line 695

You're mixing tabs and spaces there.

Otherwise it looks good and tests pass now (at least the ones I tried)

review: Needs Fixing

Revision history for this message

Daniel d'Andrada (dandrader) on 2015-10-16: Posted in a previous version of this proposal

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-16: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6486/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-26: Posted in a previous version of this proposal

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6534/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~unity-team/unity8/new_fix_upsidedown updated on 2015-10-26

1946. By Michał Sawicz on 2015-10-26: Merge lp:~mzanetti/unity8/panel-button-fixes

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-26:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6536/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~unity-team/unity8/new_fix_upsidedown updated on 2015-10-26

1947. By Michał Sawicz on 2015-10-26: Bump QtQuick import

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-27:

FAILED: Continuous integration, rev:1947
http://jenkins.qa.ubuntu.com/job/unity8-ci/6553/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4833
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-wily-touch/936/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1265
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-wily/581/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/1160
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/1161
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-wily-amd64-ci/792/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity8-wily-i386-ci/793/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3891
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4830
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4830/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24578
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-wily-armhf/936/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6553/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-27:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6556/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~unity-team/unity8/new_fix_upsidedown updated on 2015-10-27

1948. By Michał Sawicz on 2015-10-27: lp:~mzanetti/unity8/panel-button-fixes

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-28:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6572/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michał Sawicz (saviq) wrote on 2015-10-28:

This seems to enable rotation when connected to an external screen.

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-28:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6578/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~unity-team/unity8/new_fix_upsidedown updated on 2015-10-28

1949. By Daniel d'Andrada on 2015-10-28: DeviceConfiguration.qml: Fix bogus merge with trunk

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-10-28:

> This seems to enable rotation when connected to an external screen.

Fixed. Was due to a bogus merge with trunk.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-29:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6586/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~unity-team/unity8/new_fix_upsidedown updated on 2015-10-29

1950. By Daniel d'Andrada on 2015-10-29: Another bug from a bad merge with trunk
1951. By Daniel d'Andrada on 2015-10-29: Fix

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-29:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6587/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-29:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6596/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michał Sawicz (saviq) wrote on 2015-10-29:

qmltestrunner.OrientedShell::test_moveToExternalMonitor
property transformRotationAngle Actual (): 90 Expected (): 0

review: Needs Fixing

lp://qastaging/~unity-team/unity8/new_fix_upsidedown updated on 2015-10-30

1952. By Daniel d'Andrada on 2015-10-30: Fix bug in OrientedShell.orientationChangesEnabled

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2015-10-30:

> qmltestrunner.OrientedShell::test_moveToExternalMonitor
> property transformRotationAngle Actual (): 90 Expected (): 0

Fixed. It was actually a bug in trunk!

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-31:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6608/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michał Sawicz (saviq) wrote on 2015-11-05:

All fixed, thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Mohammad Rakibul Hasan

Unity Team