lp://qastaging/~unity-team/unity8/wizard-auto-shutdown

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp://qastaging/unity8

Andrea Cimitan (community): Approve on 2015-02-09

PS Jenkins bot (community): Approve (continuous-integration) on 2015-02-06

Michael Terry: Approve on 2015-02-06

Diff: 189 lines (+84/-0)

8 files modified

qml/Wizard/Pages.qml (+2/-0)
qml/Wizard/Wizard.qml (+10/-0)
tests/mocks/Unity/CMakeLists.txt (+1/-0)
tests/mocks/Unity/Session/CMakeLists.txt (+1/-0)
tests/mocks/Unity/Session/DBusUnitySessionService.qml (+24/-0)
tests/mocks/Unity/Session/Session.qmltypes (+22/-0)
tests/mocks/Unity/Session/qmldir (+3/-0)
tests/qmltests/Wizard/tst_Wizard.qml (+21/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1418967: Leaving wizard idle should shut down the phone

Low

Triaged

Link a bug report

Related blueprints

1600. By Michał Sawicz on 2015-02-06

Move signal emission up

1599. By Michał Sawicz on 2015-02-06

Fix better, and tweak the test a bit

1598. By Michał Sawicz on 2015-02-06

And make it a QtObject

1597. By Michał Sawicz on 2015-02-06

Fix qmltypes

1596. By Michał Sawicz on 2015-02-06

The lowercase methods don't exist on the real implementation

1595. By Michał Sawicz on 2015-02-06

Fix version and revert plugin changes

1594. By Michał Sawicz on 2015-02-06

Shut down the phone if the wizard does not see interaction for 2 minutes

1593. By CI Train Bot Account on 2015-02-05

Releasing 8.02+15.04.20150205-0ubuntu1

1592. By Michael Terry on 2015-02-05

Don't accept multiple "Finish" clicks during the last step of the wizard

Doing so can cause password-setting to be left in an inconsistent state.
Here's how that happens:

A) User clicks Finish multiple times, queuing up multiple input events (queued because Finish makes some blocking calls).
B) The first Finish starts, let's say it's called with new password "1111" and type "passcode". The current password is "" with a type of "swipe".
C) The first Finish completes, having set the password correctly to 1111/passcode.
D) The second Finish starts. Also called with "1111/passcode". But it still thinks the current type is "swipe" because it takes a moment for AccountsService to update itself.
E) The second Finish first changes the display mode hint to "passcode"
F) Then the second Finish can't change the password because it's trying to authenticate using "" when the password is actually "1111" now.
G) So the second Finish enters the "error mode cleanup" stage and tries to revert its display mode hint change from step E. But it's reverting to what it thought the previous type was -- "swipe" -- which uses the "passphrase" hint behind the scenes (instead of "passcode")

Some possible solutions to this:
- Cache the password type locally instead of waiting for AccountsService to update (not a bad idea, but would be done in ubuntu-system-settings, not unity8)
- Don't let the user click the Finish button twice. This seems like a no-brainer that should be done anyway. This would also avoid the whole problem.

To reproduce this bug / test this fix, enable the wizard, enter adb, run "sudo passwd -d phablet", reboot, then go through the wizard but just keep spamming that final Finish button. You'll also notice some slow down because it's trying to do all those Finish operations. Fixes: #1414762
Approved by: Albert Astals Cid

1591. By Andrea Cimitan on 2015-02-05

Background needs to be specified to be visible in horizontal cards Fixes: #1411748
Approved by: Albert Astals Cid