Merge lp://qastaging/~urbanape/ubuntuone-ios-music/fix-album-scroll-lag into lp://qastaging/ubuntuone-ios-music
Proposed by
Zachery Bir
| Status: | Merged |
|---|---|
| Approved by: | Zachery Bir |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 220 |
| Proposed branch: | lp://qastaging/~urbanape/ubuntuone-ios-music/fix-album-scroll-lag |
| Merge into: | lp://qastaging/ubuntuone-ios-music |
| Diff against target: |
1083 lines (+308/-292) 11 files modified
U1Music-Info.plist (+2/-2) about/about.html (+1/-1) utilities/Globals.h (+1/-0) utilities/Globals.m (+6/-0) utilities/operations/AlbumArtLoader.h (+1/-2) utilities/operations/AlbumArtLoader.m (+76/-22) view_controllers/AlbumListViewController.m (+11/-35) view_controllers/AlbumViewController.m (+11/-10) view_controllers/ArtistViewController.m (+11/-35) view_controllers/SongViewController.m (+11/-5) xibs/SongViewController.xib (+177/-180) |
| To merge this branch: | bzr merge lp://qastaging/~urbanape/ubuntuone-ios-music/fix-album-scroll-lag |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paul Hummer (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch attempts to fix the scroll lag seen on the Albums view by fetching, resizing, and loading the images in the background.
I think there is still some work to be done, since I can still make the view lag a bit on first load (via the network).
To post a comment you must log in.
Revision history for this message
| Paul Hummer (rockstar) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
