camera-app

Merge lp://qastaging/~uriboni/camera-app/handle-selfie-key into lp://qastaging/camera-app

  1. handle-selfie-key
  2. Merge into trunk
Proposed by Ugo Riboni
Status: Needs review
Proposed branch: lp://qastaging/~uriboni/camera-app/handle-selfie-key
Merge into: lp://qastaging/camera-app
Diff against target: 124 lines (+39/-10)
4 files modified
ViewFinderOverlay.qml (+29/-9)
ViewFinderOverlayLoader.qml (+5/-0)
ViewFinderView.qml (+2/-1)
camera-app.qml (+3/-0)
To merge this branch: bzr merge lp://qastaging/~uriboni/camera-app/handle-selfie-key
Reviewer Review Type Date Requested Status
Florian Boucault (community) Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+283992@code.qastaging.launchpad.net

Commit message

Handle various keypresses that are used by selfie sticks to trigger shooting

Description of the change

Handle various keypresses that are used by selfie sticks to trigger shooting

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:624
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~uriboni/camera-app/handle-selfie-key/+merge/283992/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/camera-app-ci/482/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/177
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/178
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/178/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/177
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/380
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-touch/1051
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/934
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27054

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/482/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

Grabbed the deb from the jenkins run and installed it on my bq e4.5. I paired my selfie button and when I press the Android (enter key) button, nothing happens. When I press the iOS button (vol+) I get the volume overlay appear. Like this:-

http://people.canonical.com/~alan/screenshots/device-2016-02-03-113625.png

No photos are taken.

Reply
Revision history for this message
Florian Boucault (fboucault) wrote :

@Ugo: Submitted against wrong branch.
@Alan: camera is distributed as a click app so installing the deb while the original click is installed would cause the click to be run instead of the deb version.

Reply
Revision history for this message
Florian Boucault (fboucault) wrote :

There were changes to keyboard handling in staging in the meantime, please make sure it merges with no breakages.

review: Needs Fixing
Reply

Unmerged revisions

624. By Ugo Riboni

Shoot a picture on almost all media keys
with the exception of those used by the system for volume up and down

623. By Ugo Riboni

Merge changes from trunk

622. By Ugo Riboni

Focus the overlay so that it can receive keypresses, and then handle the togglePlayPause media key to shoot a picture

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches