camera-app

Merge lp://qastaging/~uriboni/camera-app/no-permissions-dialog into lp://qastaging/camera-app/staging

no-permissions-dialog
Merge into staging

Proposed by Ugo Riboni on 2015-12-02

Status:

Merged

Approved by:

Florian Boucault on 2015-12-16

Approved revision:

623

Merged at revision:

623

Proposed branch:

lp://qastaging/~uriboni/camera-app/no-permissions-dialog

Merge into:

lp://qastaging/camera-app/staging

Diff against target:

52 lines (+44/-0)

1 file modified

ViewFinderOverlay.qml (+44/-0)

To merge this branch:

bzr merge lp://qastaging/~uriboni/camera-app/no-permissions-dialog

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-12-16
Florian Boucault (community)		2015-12-02	Needs Fixing on 2015-12-08
Review via email: mp+279260@code.qastaging.launchpad.net

Commit message

Notify the user when camera permissions have been revoked, and provide shortcut to change them again

Description of the change

Notify the user when camera permissions have been revoked, and provide shortcut to change them again

Needs https://code.launchpad.net/~phablet-team/ubuntu-system-settings/permission-page-url/+merge/279883 to be merged in content-hub to allow going directly the right settings page. Without it just goes to the Security&Privacy page (two levels down from where the user needs to go)

lp://qastaging/~uriboni/camera-app/no-permissions-dialog updated on 2015-12-08

620. By Ugo Riboni on 2015-12-08: Allow reaching the camera permissions page directly. Fix some text.
621. By Ugo Riboni on 2015-12-08: Better text, including suggestions to reboot if permissions are ok

Revision history for this message

Florian Boucault (fboucault) wrote on 2015-12-08:

semi columns at end of JS lines please.

review: Needs Fixing

Revision history for this message

Florian Boucault (fboucault) wrote on 2015-12-08:

Would not a better solution be for the trust prompt that requests access to the camera to reappear as it does the first time you launch the camera app?

Revision history for this message

Ugo Riboni (uriboni) wrote on 2015-12-10:

> Would not a better solution be for the trust prompt that requests access to
> the camera to reappear as it does the first time you launch the camera app?

Probably, but I think there is a difference in removing the app from the trust store (which causes a prompt on next launch) and disabling it (which causes the app to silently be denied access).

The control panel just disables the app but it leaves the entry in trust store, so that the user can go there and re-enable it if needed.
If we change the control panel's logic to actually remove the app from the store, then the only way to re-enable it would be to launch it again.

All other services (GPS, microphone) also work in this way, so we either change all or none.

lp://qastaging/~uriboni/camera-app/no-permissions-dialog updated on 2015-12-10