camera-app

Merge lp://qastaging/~uriboni/camera-app/rotate-popovers into lp://qastaging/camera-app/staging

  1. rotate-popovers
  2. Merge into staging
Proposed by Ugo Riboni
Status: Merged
Approved by: Florian Boucault
Approved revision: 614
Merged at revision: 614
Proposed branch: lp://qastaging/~uriboni/camera-app/rotate-popovers
Merge into: lp://qastaging/camera-app/staging
Diff against target: 119 lines (+23/-9)
4 files modified
DeleteDialog.qml (+1/-3)
GalleryView.qml (+1/-0)
PhotogridView.qml (+11/-4)
SlideshowView.qml (+10/-2)
To merge this branch: bzr merge lp://qastaging/~uriboni/camera-app/rotate-popovers
Reviewer Review Type Date Requested Status
Florian Boucault (community) Needs Fixing
Review via email: mp+278685@code.qastaging.launchpad.net

Commit message

Correctly rotate the share and delete dialogs by parenting them to the views that trigger them

Description of the change

Correctly rotate the share and delete dialogs by parenting them to the views that trigger them

To post a comment you must log in.
Revision history for this message
Florian Boucault (fboucault) wrote :

PopupUtils.open(sharePopoverComponent).parent = photogridView

2 non obvious things in one line, please make it 2 lines

review: Needs Fixing
lp://qastaging/~uriboni/camera-app/rotate-popovers updated
614. By Ugo Riboni

Make code more readable

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches