camera-app

Merge lp://qastaging/~uriboni/camera-app/switch-via-camera-position-api into lp://qastaging/camera-app/staging

  1. switch-via-camera-position-api
  2. Merge into staging
Proposed by Ugo Riboni
Status: Merged
Approved by: Florian Boucault
Approved revision: 652
Merged at revision: 689
Proposed branch: lp://qastaging/~uriboni/camera-app/switch-via-camera-position-api
Merge into: lp://qastaging/camera-app/staging
Diff against target: 300 lines (+48/-48)
5 files modified
CameraApp/advancedcamerasettings.cpp (+30/-26)
CameraApp/advancedcamerasettings.h (+4/-6)
ViewFinderGeometry.qml (+2/-2)
ViewFinderOverlay.qml (+10/-11)
ViewFinderView.qml (+2/-3)
To merge this branch: bzr merge lp://qastaging/~uriboni/camera-app/switch-via-camera-position-api
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+286498@code.qastaging.launchpad.net

Commit message

Set Camera.position to switch front/back cameras instead of AdvancedCameraSettings and hardcoded camera indexes

Description of the change

Set Camera.position to switch front/back cameras instead of AdvancedCameraSettings and hardcoded camera indexes

Note that https://code.launchpad.net/~uriboni/qtubuntu-camera/cameras-info/+merge/286283 is required for this to work

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:651
http://jenkins.qa.ubuntu.com/job/camera-app-staging-ci/36/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-amd64-ci/36
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-amd64-ci/36/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-armhf-ci/36
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-armhf-ci/36/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-i386-ci/36
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-i386-ci/36/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/410
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-touch/1080
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/998
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27740

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-staging-ci/36/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~uriboni/camera-app/switch-via-camera-position-api updated
652. By Ugo Riboni

Merge changes from parent branch

Revision history for this message
Florian Boucault (fboucault) wrote :

Works well, thank you

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches