Merge lp://qastaging/~uriboni/unity-2d/launcher-eject-with-ui-if-blocked into lp://qastaging/unity-2d/3.0
Proposed by
Ugo Riboni
| Status: | Merged |
|---|---|
| Approved by: | Florian Boucault |
| Approved revision: | 433 |
| Merged at revision: | 437 |
| Proposed branch: | lp://qastaging/~uriboni/unity-2d/launcher-eject-with-ui-if-blocked |
| Merge into: | lp://qastaging/unity-2d/3.0 |
| Diff against target: |
46 lines (+13/-2) 1 file modified
launcher/UnityApplications/launcherdevice.cpp (+13/-2) |
| To merge this branch: | bzr merge lp://qastaging/~uriboni/unity-2d/launcher-eject-with-ui-if-blocked |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Florian Boucault (community) | code | Needs Fixing | |
|
Review via email:
|
|||
Commit message
[launcher] Make sure that when unmounting/ejecting a device Gnome pops up the dialog informing the user about which applications are holding the device busy preventing the eject.
Description of the change
Make sure that when unmounting/ejecting a device Gnome pops up the dialog informing the user about which applications are holding the device busy preventing the eject.
Note for the reviewer: there are two code paths inside LauncherDevice:
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good!
Do not use the 'mount_op' abbreviation, prefer 'mount_operation' instead. Thanks.