unity-2d

Merge lp://qastaging/~uriboni/unity-2d/spread-no-windows-when-inactive into lp://qastaging/unity-2d/3.0

  1. spread-no-windows-when-inactive
  2. Merge into natty
Proposed by Ugo Riboni
Status: Merged
Approved by: Florian Boucault
Approved revision: 536
Merged at revision: 536
Proposed branch: lp://qastaging/~uriboni/unity-2d/spread-no-windows-when-inactive
Merge into: lp://qastaging/unity-2d/3.0
Diff against target: 44 lines (+8/-5)
1 file modified
libunity-2d-private/Unity2d/windowslist.cpp (+8/-5)
To merge this branch: bzr merge lp://qastaging/~uriboni/unity-2d/spread-no-windows-when-inactive
Reviewer Review Type Date Requested Status
Florian Boucault (community) Approve
Review via email: mp+57857@code.qastaging.launchpad.net

Description of the change

[spread] While the spread is not active avoid creating WindowInfo instances for windows that are opened

To post a comment you must log in.
Revision history for this message
Ugo Riboni (uriboni) wrote :

The only way to verify that this patch works as advertised is to actually go in with a debugger and verify that the WindowsList has still zero items after a new window has been created while the spread is active.

Revision history for this message
Ugo Riboni (uriboni) wrote :

I meant, "while the spread is *not* active", at the end of the previous comment.

Revision history for this message
Florian Boucault (fboucault) wrote :

Works fine. Note 753269 is merely related to that MR, not fixed by it.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: