webbrowser-app

Merge lp://qastaging/~uriboni/webbrowser-app/reset-focus-tab-change into lp://qastaging/webbrowser-app

  1. reset-focus-tab-change
  2. Merge into trunk
Proposed by Ugo Riboni
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 1151
Merged at revision: 1161
Proposed branch: lp://qastaging/~uriboni/webbrowser-app/reset-focus-tab-change
Merge into: lp://qastaging/webbrowser-app
Diff against target: 85 lines (+57/-0)
2 files modified
src/app/webbrowser/Browser.qml (+1/-0)
tests/autopilot/webbrowser_app/tests/test_tabs.py (+56/-0)
To merge this branch: bzr merge lp://qastaging/~uriboni/webbrowser-app/reset-focus-tab-change
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Olivier Tilloy Approve
Riccardo Padovani (community) Approve
Review via email: mp+269083@code.qastaging.launchpad.net

Commit message

Properly reset focus when the current tab changes (including as a result of closing tabs).

Description of the change

Properly reset focus on when the current tab changes (including as a result of closing tabs)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1148
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2137/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3854
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/891
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/891
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/891/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/891
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3164
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3851
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3851/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22817

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2137/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

lgtm, thanks for working on this :-)

review: Approve
Revision history for this message
Olivier Tilloy (osomon) wrote :

33 + if not self.main_window.wide:
34 + self.skipTest("Only on wide form factors")

This is not the correct check. "desktop" and wide are not equivalent. A tablet in landscape mode is a wide form factor, but it doesn’t necessarily have a physical keyboard plugged in. I am aware that this "desktop" form factor thing will break easily when we get to corner cases (tablet with a keyboard, or desktop with a touch screen, …), and this will need fixing, but for now this is what we use to identify a device that has a reasonably wide screen and a physical keyboard.

review: Needs Fixing
lp://qastaging/~uriboni/webbrowser-app/reset-focus-tab-change updated
1149. By Ugo Riboni

Run the AP tests only on systems with a keyboard

1150. By Ugo Riboni

Merge changes from trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1150
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2151/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3930
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/905
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/905
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/905/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/905
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3217
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3927
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3927/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22957

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2151/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~uriboni/webbrowser-app/reset-focus-tab-change updated
1151. By Ugo Riboni

Merge changes from trunk

Revision history for this message
Olivier Tilloy (osomon) wrote :

Looks good to me now, thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1151
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2157/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3953/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/911
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/911
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/911/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/911
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3233/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3950
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3950/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22987

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2157/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: