Merge lp://qastaging/~ursinha/landscape-charm/bug-1625307-ignore-tar-warnings into lp://qastaging/~landscape/landscape-charm/tools

Proposed by Ursula Junque
Status: Merged
Approved by: Ursula Junque
Approved revision: 32
Merged at revision: 32
Proposed branch: lp://qastaging/~ursinha/landscape-charm/bug-1625307-ignore-tar-warnings
Merge into: lp://qastaging/~landscape/landscape-charm/tools
Diff against target: 23 lines (+9/-4)
1 file modified
collect-logs (+9/-4)
To merge this branch: bzr merge lp://qastaging/~ursinha/landscape-charm/bug-1625307-ignore-tar-warnings
Reviewer Review Type Date Requested Status
Andreas Hasenack Approve
Francis Ginther (community) Approve
🤖 Landscape Builder test results Approve
Review via email: mp+306141@code.qastaging.launchpad.net

Commit message

Fixes bug #1625307: In _create_log_tarball, ignores all exceptions caused by tar returning 1 (warnings).

Description of the change

Fixes bug #1625307: In _create_log_tarball, ignores all exceptions caused by tar returning 1 (warnings).

This needs tests, but I'd need to move things around a bit to be able to do that. I'd rather do that in another branch, to get this fixed asap - we're ending up with empty logs and that makes virtually impossible to debug post-mortem system-tests.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :
review: Approve (test results)
Revision history for this message
Francis Ginther (fginther) wrote :

Approve

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

+1, thanks for the long comments

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: