Merge lp://qastaging/~ursinha/launchpad/add-date-last-changed-who-changed-to-specifications into lp://qastaging/launchpad/db-devel

Proposed by Ursula Junque
Status: Merged
Approved by: Stuart Bishop
Approved revision: no longer in the source branch.
Merged at revision: 11298
Proposed branch: lp://qastaging/~ursinha/launchpad/add-date-last-changed-who-changed-to-specifications
Merge into: lp://qastaging/launchpad/db-devel
Diff against target: 3284 lines (+702/-1593)
45 files modified
buildout.cfg (+1/-1)
database/schema/patch-2209-04-0.sql (+17/-0)
lib/canonical/launchpad/icing/css/base.css (+3/-0)
lib/canonical/launchpad/icing/css/components/bug_listing.css (+3/-6)
lib/lp/app/javascript/comment.js (+17/-15)
lib/lp/app/javascript/extras/extras.js (+0/-2)
lib/lp/app/javascript/foldables.js (+0/-1)
lib/lp/app/javascript/sorttable/sorttable.js (+467/-307)
lib/lp/app/javascript/tests/test_foldables.js (+0/-1)
lib/lp/app/templates/base-layout-macros.pt (+4/-3)
lib/lp/archiveuploader/tests/nascentuploadfile.txt (+0/-31)
lib/lp/bugs/browser/tests/test_bugtask.py (+1/-1)
lib/lp/bugs/doc/externalbugtracker-comment-imports.txt (+0/-17)
lib/lp/bugs/scripts/bugimport.py (+3/-22)
lib/lp/bugs/scripts/tests/test_bugimport.py (+0/-28)
lib/lp/bugs/templates/buglisting.mustache (+54/-54)
lib/lp/registry/doc/person-account.txt (+5/-14)
lib/lp/registry/doc/person.txt (+1/-7)
lib/lp/registry/model/person.py (+51/-111)
lib/lp/registry/tests/test_mailinglistapi.py (+0/-4)
lib/lp/registry/tests/test_personset.py (+0/-81)
lib/lp/registry/xmlrpc/mailinglist.py (+0/-1)
lib/lp/scripts/garbo.py (+1/-1)
lib/lp/security.py (+30/-11)
lib/lp/services/identity/doc/account.txt (+4/-160)
lib/lp/services/identity/interfaces/account.py (+1/-102)
lib/lp/services/identity/interfaces/emailaddress.py (+2/-7)
lib/lp/services/identity/model/account.py (+1/-165)
lib/lp/services/identity/model/emailaddress.py (+3/-22)
lib/lp/services/identity/tests/test_account.py (+1/-241)
lib/lp/services/mail/incoming.py (+0/-6)
lib/lp/services/mail/tests/test_incoming.py (+0/-7)
lib/lp/services/verification/browser/logintoken.py (+2/-11)
lib/lp/services/webapp/authentication.py (+6/-8)
lib/lp/services/webapp/login.py (+3/-3)
lib/lp/services/webapp/publication.py (+4/-3)
lib/lp/services/webapp/tests/test_authentication.py (+1/-37)
lib/lp/services/webapp/tests/test_authutility.py (+2/-2)
lib/lp/services/webapp/tests/test_login.py (+4/-23)
lib/lp/services/webapp/tests/test_login_account.py (+0/-33)
lib/lp/services/webservice/configuration.py (+1/-1)
lib/lp/testing/factory.py (+6/-19)
lib/lp/testing/tests/test_login.py (+0/-7)
lib/lp/testopenid/browser/server.py (+3/-2)
lib/lp/translations/utilities/tests/test_file_importer.py (+0/-15)
To merge this branch: bzr merge lp://qastaging/~ursinha/launchpad/add-date-last-changed-who-changed-to-specifications
Reviewer Review Type Date Requested Status
Stuart Bishop (community) db Approve
Robert Collins db Pending
Launchpad code reviewers Pending
Review via email: mp+88503@code.qastaging.launchpad.net

Commit message

[r=stub][bug=916043][incr] Add date_last_changed and last_changed_by to specification.

Description of the change

This branch adds two new columns to table specification: date_last_changed and last_changed_by. These two should be updated whenever one updates a blueprint, so it's possible to know, well, when the last change was made and who did it.

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :

Looks good.

I'm told we want to order specifications by last update time, so we will need an index on that column.

review: Approve (db)
Revision history for this message
Ursula Junque (ursinha) wrote :

> Looks good.
>
> I'm told we want to order specifications by last update time, so we will need
> an index on that column.

Done!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: