Merge lp://qastaging/~ursinha/ubuntu-ci-services-itself/401-copying-di-check into lp://qastaging/ubuntu-ci-services-itself
Status: | Merged |
---|---|
Approved by: | Francis Ginther |
Approved revision: | 412 |
Merged at revision: | 412 |
Proposed branch: | lp://qastaging/~ursinha/ubuntu-ci-services-itself/401-copying-di-check |
Merge into: | lp://qastaging/ubuntu-ci-services-itself |
Diff against target: |
80 lines (+36/-11) 1 file modified
lander/bin/ppa_sync.py (+36/-11) |
To merge this branch: | bzr merge lp://qastaging/~ursinha/ubuntu-ci-services-itself/401-copying-di-check |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Francis Ginther | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Vincent Ladeuil (community) | Approve | ||
Review via email: mp+211619@code.qastaging.launchpad.net |
Commit message
Adding a check when the Unauthorized exception is raised during ppa_sync.copy() to see if the source is present in target PPA
Description of the change
Launchpad doesn't support copying packages with debian-installer to PPAs, that works only if destination is primary archive, and this causes a 401 Unauthorized error when ppa_sync tries to copy the generated kernel from a build pool's PPA to our master PPA, as it has debian-installer packages.
The good news is that this error happens only after the source and binaries were successfully copied, so this branch adds a check when the Unauthorized exception is raised to see if the source is present in target PPA. If so, that means we hit that bug and the files we need are on the master PPA already, so we can report publish step successfully completed. If not, we raise the Unauthorized error as this is something else going wrong.
Crystal clear.