Merge lp://qastaging/~ursinha/ubuntu-ci-services-itself/fix-unicode-bug-1286233 into lp://qastaging/ubuntu-ci-services-itself
Proposed by
Ursula Junque
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Chris Johnston | ||||
| Approved revision: | 292 | ||||
| Merged at revision: | 348 | ||||
| Proposed branch: | lp://qastaging/~ursinha/ubuntu-ci-services-itself/fix-unicode-bug-1286233 | ||||
| Merge into: | lp://qastaging/ubuntu-ci-services-itself | ||||
| Diff against target: |
55 lines (+24/-6) 2 files modified
cli/ci_libs/status.py (+7/-6) cli/tests/test_get_ticket_status.py (+17/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~ursinha/ubuntu-ci-services-itself/fix-unicode-bug-1286233 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Andy Doan (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Adding encoding protection so in case a ticket title has unicode chars ubuntu-ci status won't blow up
Description of the change
This branch handles ticket titles that contain unicode chars, avoiding cli status command to fail with UnicodeEncodeError.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:292
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http://
Executed test runs:
Click here to trigger a rebuild:
http://