Ubuntu CI Services

Merge lp://qastaging/~ursinha/ubuntu-ci-services-itself/ppa-assigner-checking-date-made-pending into lp://qastaging/ubuntu-ci-services-itself

ppa-assigner-checking-date-made-pending
Merge into trunk

Proposed by Ursula Junque on 2014-02-28

Status:	Merged
Approved by:	Evan on 2014-02-28
Approved revision:	291
Merged at revision:	297
Proposed branch:	lp://qastaging/~ursinha/ubuntu-ci-services-itself/ppa-assigner-checking-date-made-pending
Merge into:	lp://qastaging/ubuntu-ci-services-itself
Diff against target:	94 lines (+29/-9) 4 files modified ppa-assigner/ppa_assigner/launchpad.py (+21/-1) ppa-assigner/ppa_assigner/management/commands/clean_ppas.py (+1/-1) ppa-assigner/ppa_assigner/ppa_sync.py (+1/-1) ppa-assigner/ppa_assigner/tests.py (+6/-6)
To merge this branch:	bzr merge lp://qastaging/~ursinha/ubuntu-ci-services-itself/ppa-assigner-checking-date-made-pending
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2014-02-28
Evan (community)		2014-02-28	Approve on 2014-02-28
Review via email: mp+208728@code.qastaging.launchpad.net

Commit message

Changing ppa_assigner to check for date_made_pending instead of date_removed

Description of the change

This branch changes ppa_assigner to check for date_made_pending instead of date_removed on a package publishing record. This should save us time while waiting for the PPA to be freed to use again.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-28:

PASSED: Continuous integration, rev:289
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/260/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/260/rebuild

review: Approve (continuous-integration)

Revision history for this message

Evan (ev) wrote on 2014-02-28:

Could you provide a comment in the code on what effect checking date_made_pending has? Perhaps even just your commit message:

spph/bpph.date_removed is set by process-death-row, that runs every 6 hours; scheduled_deletion_time is set when the publisher removes the entry from the indices, so the package don't exist anymore from this point on. Checking if this is set should be enough to ensure the package is 'gone'

review: Needs Fixing

Revision history for this message

Evan (ev) wrote on 2014-02-28:

+1 otherwise.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-28:

PASSED: Continuous integration, rev:290
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/262/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/262/rebuild

review: Approve (continuous-integration)

lp://qastaging/~ursinha/ubuntu-ci-services-itself/ppa-assigner-checking-date-made-pending updated on 2014-02-28

291. By Ursula Junque on 2014-02-28: Adding comment to launchpad.py explaining why the change to date_made_pending

Revision history for this message

Ursula Junque (ursinha) wrote on 2014-02-28:

> Could you provide a comment in the code on what effect checking
> date_made_pending has? Perhaps even just your commit message:
>
> spph/bpph.date_removed is set by process-death-row, that runs every 6 hours;
> scheduled_deletion_time is set when the publisher removes the entry from the
> indices, so the package don't exist anymore from this point on. Checking if
> this is set should be enough to ensure the package is 'gone'

r291. Let me know if that's good enough.

Revision history for this message

Evan (ev) wrote on 2014-02-28: