Merge lp://qastaging/~valavanisalex/ubuntu/oneiric/gedit-latex-plugin/fix-897346 into lp://qastaging/ubuntu/oneiric-backports/gedit-latex-plugin
Proposed by
Alex Valavanis
| Status: | Rejected | ||||
|---|---|---|---|---|---|
| Rejected by: | Evan Broder | ||||
| Proposed branch: | lp://qastaging/~valavanisalex/ubuntu/oneiric/gedit-latex-plugin/fix-897346 | ||||
| Merge into: | lp://qastaging/ubuntu/oneiric-backports/gedit-latex-plugin | ||||
| Diff against target: |
26 lines (+7/-1) 2 files modified
debian/changelog (+6/-0) debian/control (+1/-1) |
||||
| To merge this branch: | bzr merge lp://qastaging/~valavanisalex/ubuntu/oneiric/gedit-latex-plugin/fix-897346 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Evan Broder (community) | Disapprove | ||
|
Review via email:
|
|||
To post a comment you must log in.
Unmerged revisions
- 12. By Alex Valavanis
-
Recommend libgnome2-0 to allow use of gnome-open (LP: #897346)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I'm going to go ahead and reject this merge proposal for a handful of reasons:
First, and most importantly, we don't fix bugs directly in backports. This bug should be fixed first in the development release, at which point it could be re-backported to oneiric.
Second, I would prefer to hit two birds with one stone and upgrade to 3.3.2, which switches to gvfs-open instead of gnome-open. I've opened a bug with the Debian maintainer requesting this (Debian bug #650355)
Finally, and this is much more minor, because this package requires gnome-open for proper functioning, the libgnome2-0 should be added as a dependency of gedit-latex-plugin, not a recommendation.