Merge lp://qastaging/~vanvugt/compiz-core/fix-953089.2 into lp://qastaging/compiz-core

Proposed by Daniel van Vugt
Status: Merged
Merged at revision: 3066
Proposed branch: lp://qastaging/~vanvugt/compiz-core/fix-953089.2
Merge into: lp://qastaging/compiz-core
Diff against target: 121 lines (+35/-19)
3 files modified
src/event.cpp (+31/-18)
src/privatescreen.h (+2/-0)
src/screen.cpp (+2/-1)
To merge this branch: bzr merge lp://qastaging/~vanvugt/compiz-core/fix-953089.2
Reviewer Review Type Date Requested Status
Sam Spilsbury Approve
Review via email: mp+98833@code.qastaging.launchpad.net

Description of the change

Don't rely on the value of "grabbed" to tell you if the root window is
presently accepting key events (meaning there are no external active grabs).
There are some edge cases where grabbed is false but root is still accepting
key events, so when that happened compiz would ignore its own key shortcuts
(LP: #953089)

This was a regression caused by the fix for LP: #806255. The fix for that
bug has now been redesigned to avoid causing LP: #953089.

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches