Compiz Core

Merge lp://qastaging/~vanvugt/compiz-core/fix-981703-properly into lp://qastaging/compiz-core

fix-981703-properly
Merge into 0.9.7

Proposed by Daniel van Vugt on 2012-04-17

Status:	Superseded
Proposed branch:	lp://qastaging/~vanvugt/compiz-core/fix-981703-properly
Merge into:	lp://qastaging/compiz-core
Diff against target:	12 lines (+1/-2) 1 file modified plugins/decor/src/decor.cpp (+1/-2)
To merge this branch:	bzr merge lp://qastaging/~vanvugt/compiz-core/fix-981703-properly
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Daniel van Vugt		Needs Fixing on 2012-04-17
Sam Spilsbury	2012-04-17	Approve on 2012-04-17
Review via email: mp+102249@code.qastaging.launchpad.net

Description of the change

Make sure window frames actually get destroyed when they should, to
guarantee they get recreated on unminimize. (LP: #981703)

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2012-04-17:

Although I wonder if the entire if-statement could be simplified...

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2012-04-17:

whoops

review: Approve

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2012-04-17:

In progress again. This fix causes 2 new regressions:
1. Switcher leaves a dead zone after being unmapped.
2. Decoration buttons of unfocussed windows only respond on the second click (after being focussed?)

Revision history for this message

Daniel van Vugt (vanvugt) on 2012-04-17:

review: Needs Fixing

lp://qastaging/~vanvugt/compiz-core/fix-981703-properly updated on 2012-04-18

3096. By Daniel van Vugt on 2012-04-17: More correct fix for LP: #981703: Ensure that inputFrame is destroyed on
minimize (and CompWindowNotifyUnreparent).
3097. By Daniel van Vugt on 2012-04-17: Add FIXME comment to show where the remaining switcher problem is originating.
3098. By Daniel van Vugt on 2012-04-18: Make sure window frames actually get destroyed when they should, to
guarantee they get recreated on unminimize. (LP: #981703)