Merge lp://qastaging/~vanvugt/compiz-core/fix-alt-bugs into lp://qastaging/compiz-core
Proposed by
Daniel van Vugt
| Status: | Merged |
|---|---|
| Approved by: | Alan Griffiths |
| Approved revision: | 3046 |
| Merged at revision: | 3046 |
| Proposed branch: | lp://qastaging/~vanvugt/compiz-core/fix-alt-bugs |
| Merge into: | lp://qastaging/compiz-core |
| Diff against target: |
160 lines (+36/-15) 4 files modified
metadata/core.xml.in (+7/-0) src/event.cpp (+25/-6) src/privatescreen.h (+1/-2) src/screen.cpp (+3/-7) |
| To merge this branch: | bzr merge lp://qastaging/~vanvugt/compiz-core/fix-alt-bugs |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alan Griffiths | Approve | ||
|
Review via email:
|
|||
Description of the change
Don't keep an active keyboard grab the whole time a shortcut key is held
down. Doing so was causing multiple bugs with Unity 5, which binds to
the Alt key. Instead use some simple heurisitics to decide if a key has
been "tapped" or not. (LP: #943194) (LP: #943851) (LP: #945373)
Yes, it is a compromise to go back to detecting taps based on timing.
However it is the only existing solution to all of these bugs related to
the Alt key.
To post a comment you must log in.
Revision history for this message
| Alan Griffiths (alan-griffiths) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks sane, seems to work (not entirely sure about reproducing 943194, but it doesn't seems worse.)