Merge lp://qastaging/~vanvugt/compiz-core/fix-composite-init-fail into lp://qastaging/compiz-core
Proposed by
Daniel van Vugt
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Alan Griffiths | ||||
| Approved revision: | 3070 | ||||
| Merged at revision: | 3070 | ||||
| Proposed branch: | lp://qastaging/~vanvugt/compiz-core/fix-composite-init-fail | ||||
| Merge into: | lp://qastaging/compiz-core | ||||
| Diff against target: |
99 lines (+13/-31) 2 files modified
plugins/composite/src/privates.h (+3/-0) plugins/composite/src/screen.cpp (+10/-31) |
||||
| To merge this branch: | bzr merge lp://qastaging/~vanvugt/compiz-core/fix-composite-init-fail | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alan Griffiths | Approve | ||
| Sam Spilsbury | Approve | ||
|
Review via email:
|
|||
Description of the change
Fixed: Composite would fail to initialize even when it was the only
composite window manage running. This was because it leaked its handles
and in the unusual cases where plugin load failures cause other plugins to
unload/reload, composite would fail to init the second time.
(LP: #963465) (LP: #963264) (LP: #833729)
To post a comment you must log in.
Revision history for this message
| Alan Griffiths (alan-griffiths) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
That's fine.
The XSetSelectionOwner call is probably unnecessary as the protocol does this implicitly. But it doesn't hurt. Bonus points for making a class to wrap the selection atom.