Merge lp://qastaging/~vanvugt/compiz-core/tidy-screen-ctor-dtor into lp://qastaging/compiz-core
Proposed by
Daniel van Vugt
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://qastaging/~vanvugt/compiz-core/tidy-screen-ctor-dtor |
| Merge into: | lp://qastaging/compiz-core |
| Diff against target: |
95 lines (+40/-11) 1 file modified
src/screen.cpp (+40/-11) |
| To merge this branch: | bzr merge lp://qastaging/~vanvugt/compiz-core/tidy-screen-ctor-dtor |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Compiz Maintainers | Pending | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2012-04-19.
Description of the change
Tidy up PrivateScreen construction and destruction:
- Remove a local masking a member variable.
- Add members missing from the constructor's initialization list.
- Free more resources, more clearly, in the destructor.
Yes, this could wait till 0.9.8. Proposing it here so I don't lose it.
To post a comment you must log in.
Revision history for this message
| Sam Spilsbury (smspillaz) wrote | # |
Revision history for this message
| Alan Griffiths (alan-griffiths) wrote | # |
Unmerged revisions
- 3073. By Daniel van Vugt
-
Remove a pointless assignment (x = x)
- 3072. By Daniel van Vugt
-
Tidy up PrivateScreen construction and destruction:
- Remove a local masking a member variable.
- Add members missing from the constructor's initialization list.
- Free more resources, more clearly, in the destructor.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The releated changes to the header are not checked in here, at least if wmSnAtom became a member variable of PrivateScreen