Merge lp://qastaging/~vanvugt/compiz/fix-1021104 into lp://qastaging/compiz/0.9.8
Proposed by
Daniel van Vugt
| Status: | Superseded | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp://qastaging/~vanvugt/compiz/fix-1021104 | ||||
| Merge into: | lp://qastaging/compiz/0.9.8 | ||||
| Diff against target: |
62 lines (+18/-2) 2 files modified
plugins/opengl/src/privates.h (+1/-0) plugins/opengl/src/screen.cpp (+17/-2) |
||||
| To merge this branch: | bzr merge lp://qastaging/~vanvugt/compiz/fix-1021104 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sam Spilsbury | Approve | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2012-07-18.
Commit message
Avoid severe artifacts and flickering when using LLVMpipe (LP: #1021104)
Description of the change
Avoid severe artifacts and flickering when using LLVMpipe (LP: #1021104)
To post a comment you must log in.
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | # |
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
57 + if (mask & COMPOSITE_
58 + tmpRegion = screen->region ();
59 +
60 BoxPtr pBox = const_cast <Region> (tmpRegion.handle ())->rects;
61 int nBox = const_cast <Region> (tmpRegion.handle ())->numRects;
62 int y;
I feel like this is in a bit of a weird place - I initially thought we could add a callback for into GLScreen to query this, but that could be even more awkward.
I'd like to see some tests for this behaviour if possible.
Otherwise, looks fine (even if I don't personally like driver detection based workarounds).