lp://qastaging/~vanvugt/compiz/fix-1041047

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://qastaging/compiz/0.9.8 at revision 3340

Sam Spilsbury: Approve on 2012-09-05

jenkins (community): Approve (continuous-integration) on 2012-09-05

Diff: 93 lines (+78/-0)

2 files modified

plugins/opengl/src/paint.cpp (+17/-0)
tests/manual/Unredirect.txt (+61/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1041047: "Unredirect Fullscreen Windows" stay on top (unredirected) even when they're not on top any more (or the output is transformed)

High

Fix Released

Link a bug report

Related blueprints

3339. By Daniel van Vugt on 2012-09-05

Ensure unredirected windows don't stay unredirected if they're no longer
on top. (LP: #1041047)

Still one minor bug: Redirecting an unredirected window, you see a brief
flicker which looks like the previous frame from before the window was
unredirected.

3338. By Daniel van Vugt on 2012-09-05

Make "Unredirect Fullscreen Windows" more reliable. This fixes the problem
with unredirection failing to engage at all (LP: #1041066) when
gtk-window-decorator creates offscreen windows that are stacked on top.
This also fixes the problem with unredirect hiding all windows,
because it thinks the desktop window should be stacked on top (LP: #980663).

Unfortunately, both issues are so tightly coupled that they can only really
be fixed and tested together.. Fixes: https://bugs.launchpad.net/bugs/980663, https://bugs.launchpad.net/bugs/1041066. Approved by Sam Spilsbury.

3337. By Sam Spilsbury on 2012-09-05

  Remove serialization.

  Serialization was a cool idea for handling the temp load/unload problem,
  however the usecase these days does not often involve that in order
  to justify its continued maintainence.
. Fixes: . Approved by Daniel van Vugt.

3336. By Daniel van Vugt on 2012-09-05

Avoid division by zero, if plugins try to deform a window down to size zero.
(LP: #1045235). Fixes: https://bugs.launchpad.net/bugs/1045235. Approved by Tim Penhey.

3335. By Daniel van Vugt on 2012-09-04

Clean up capitalization:
  UnMinimize --> Unminimize
  unMinimize --> unminimize
(LP: #1045652). Fixes: https://bugs.launchpad.net/bugs/1045652. Approved by Sam Spilsbury, MC Return.

3334. By Daniel d'Andrada on 2012-09-04

resize plugin: don't crash if resize wasn't initiated externally
(LP: #1045191)

The rectangle grabWindowWorkArea is not created if the resize is initiated by the initiate_button action (by default, alt + middle mouse button) instead of by dragging the window border.

In this situation ResizeLogic::enableOrDisableVerticalMaximization() calling member functions of a null grabWindowWorkArea.. Fixes: https://bugs.launchpad.net/bugs/1045191. Approved by Daniel van Vugt, Sam Spilsbury.

3333. By Daniel van Vugt on 2012-09-04

Fix obvious omissions from the introduction of unminimize_* (r3311), which
were causing the unminimize animation settings to be ignored (LP: #1040455). Fixes: https://bugs.launchpad.net/bugs/1040455. Approved by Sam Spilsbury.

3332. By Sam Spilsbury on 2012-08-31

Fixes FTBFS for kde4-window-decorator (LP: #1041310). Fixes: https://bugs.launchpad.net/bugs/1041310. Approved by Daniel van Vugt.

3331. By Daniel van Vugt on 2012-08-31

Updated AUTHORS from the full bzr log, and re-sort the list.
(LP: #1042095). Fixes: https://bugs.launchpad.net/bugs/1042095. Approved by Sam Spilsbury.

3330. By Sam Spilsbury on 2012-08-31

Refactors a little bit of the upgrade code and gets it under test to prepare to fix (LP: #1042537).

1. Split up ccsCheckForSettingsUpgrade into a few smaller functions
2. Consolidate some duplicate functions
3. Get those duplicate functions involving a bit of logic under test
4. Fix some invalid code in the settings upgrade function (found by manual testing). Fixes: . Approved by Daniel van Vugt.