Merge lp://qastaging/~vanvugt/compiz/fix-1057263 into lp://qastaging/compiz/0.9.8
Proposed by
Daniel van Vugt
| Status: | Merged |
|---|---|
| Approved by: | Daniel van Vugt |
| Approved revision: | 3399 |
| Merged at revision: | 3401 |
| Proposed branch: | lp://qastaging/~vanvugt/compiz/fix-1057263 |
| Merge into: | lp://qastaging/compiz/0.9.8 |
| Diff against target: |
83 lines (+26/-3) 5 files modified
gtk/window-decorator/decorator.c (+10/-1) gtk/window-decorator/events.c (+8/-1) gtk/window-decorator/gtk-window-decorator.c (+1/-1) gtk/window-decorator/gtk-window-decorator.h (+1/-0) gtk/window-decorator/wnck.c (+6/-0) |
| To merge this branch: | bzr merge lp://qastaging/~vanvugt/compiz/fix-1057263 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sam Spilsbury | Approve | ||
| jenkins (community) | continuous-integration | Needs Fixing | |
|
Review via email:
|
|||
Commit message
Some decoration pixmaps get leaked on window resize, due to race conditions
between gtk-window-
That's a complex problem which requires a better interprocess communication
and resource ownership design. So I'm not trying to fix that directly.
Instead, what this does is limits pixmap leaks to the lifetime of the frame
window. So if any leaks do occur, they will be cleaned up and freed next
time the window is minimized or closed. Or to garbage collect for all windows,
just hit Ctrl+Alt+D twice.
(LP: #1057263)
Description of the change
See commit message.
To post a comment you must log in.
Revision history for this message
| jenkins (martin-mrazik+qa) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:3399
http://
Executed test runs:
FAILURE: http://