Merge lp://qastaging/~vanvugt/mir/common7 into lp://qastaging/mir

FAILED: Continuous integration, rev:3677
https://mir-jenkins.ubuntu.com/job/mir-ci/1558/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/1947/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2007
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1998
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1998
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/1998
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/1973
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/1973/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/1973
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/1973/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/1973
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/1973/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/1973/console
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/1973/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/1973
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/1973/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/1973
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/1973/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1558/rebuild

^^^
Bug 1560909

FAILED: Continuous integration, rev:3678
https://mir-jenkins.ubuntu.com/job/mir-ci/1559/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/1948/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2008
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1999
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1999
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/1999
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/1974
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/1974/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/1974
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/1974/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/1974
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/1974/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/1974
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/1974/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/1974/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/1974
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/1974/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1559/rebuild

> Admittedly this is not a retrospective fix but it is a new more clean break
> that removes the offending duplication. I don't think a proper retrospective
> fix (duplicating the class in two different versions) is worth the effort.

I would a retrospective fix.

> Our consumers won't notice the difference because this is all C++. So if any
> downstreams are using it then they're doing so via libmirserver which still
> breaks ABIs most releases anyway. Users of libmirclient don't have /direct/
> linkage to the affected C++ symbols in libmircommon (as verified by the test
> 'Clients-only-use-client-symbols').

While they may currently be hypothetical, the plan is for downstreams to use lp:miral to avoid the libmirserver ABI breaks. Such downstreams will be dependent on libmircommon without being dependent on libmirserver. That means we should make the effort to maintain the libmircommon ABI.

Sadly, this horse is out of the barn: the LTS has Mir-0.21 with libmircommon5 (libmircommon6 was introduced in Mir-0.23).

If Yakkety ships with Mir-0.24/libmircommon6 then I'd like to keep the libmircommon6 ABI.

^^^
Jenkins failure is bug 1394369. Haven't seen that in a long time.

I was happy to say 'Won't Fix' for the 0.24 series. We could say 'Won't Fix' everywhere. Depends if a second and third user reports the same bug...

PASSED: Continuous integration, rev:3679
https://mir-jenkins.ubuntu.com/job/mir-ci/1562/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/1951
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2011
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2002
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2002
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2002
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/1977
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/1977/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/1977
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/1977/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/1977
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/1977/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/1977
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/1977/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/1977
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/1977/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/1977
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/1977/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1562/rebuild

> While they may currently be hypothetical, the plan is for downstreams to use
> lp:miral to avoid the libmirserver ABI breaks. Such downstreams will be
> dependent on libmircommon without being dependent on libmirserver. That means
> we should make the effort to maintain the libmircommon ABI.

Hmm, my understanding is a bit different. I thought that mircommon was merely split out as 'common' to share code between mirserver and mirclient, so its only as stable as the mirserver stuff.

> > While they may currently be hypothetical, the plan is for downstreams to use
> > lp:miral to avoid the libmirserver ABI breaks. Such downstreams will be
> > dependent on libmircommon without being dependent on libmirserver. That
> means
> > we should make the effort to maintain the libmircommon ABI.
>
> Hmm, my understanding is a bit different. I thought that mircommon was merely
> split out as 'common' to share code between mirserver and mirclient, so its
> only as stable as the mirserver stuff.

We *want* a stable "server" ABI but libmirserver is a long way from that. libmircommon is less of a problem, and we could make the effort there.

libmiral is an approach to wrapping libmirserver, but there are things available from libmircommon (like Rectangle) that there seems little point in re-inventing if we try to keep it ABI stable. That is the plan.

It's worth remembering changing the mircommon ABI is only a problem if it happens more frequently than mirserver.

We see a server ABI break coming in Mir 0.25 here:
https://code.launchpad.net/~andreas-pokorny/mir/fixes-and-bandaid-for-1523621/+merge/304490

So it's harmless to bump the mircommon ABI at the same or less frequency.

This change here in particular provides absolute resolution of the symbol problem of bug 1617865. It won't happen any more if binaries are looking for libmircommon.so.7 instead of the broken libmircommon.so.6.

So yes I agree we don't want to bump ABIs, but if we do bump mirserver in a release then we can bump mircommon for free. And we should because of bug 1617865.

I also choose to maintain a simple view of the world and ignore mirAL until its bits get merged into lp:mir. Then it becomes relevant to us here.

> I also choose to maintain a simple view of the world and ignore mirAL until
> its bits get merged into lp:mir. Then it becomes relevant to us here.

Has there been a failure of communication?

As soon as MirAL is in archive it becomes relevant here. Merging bits back is a long term goal.

Yes, MirAL entering archive is news to me so there was a failure of communication (or failure of my listening). Although I don't like the idea of us publishing temporary projects I can see how publishing that one will speed us up.

However...
  (1) Is there an opportunity right now for us to land this ABI cleanup/break before our downstreams get fixated on one indefinite MirAL ABI?
  (2) Are you sure that consumers of MirAL are also bound to the libmircommon ABI? Or do we have an opportunity still to strengthen APIs to ensure that dependency doesn't leak into consumers of MirAL headers?

> Yes, MirAL entering archive is news to me so there was a failure of
> communication (or failure of my listening). Although I don't like the idea of
> us publishing temporary projects I can see how publishing that one will speed
> us up.
>
> However...
> (1) Is there an opportunity right now for us to land this ABI cleanup/break
> before our downstreams get fixated on one indefinite MirAL ABI?

It depends.

I don't think the qtmir integration work will complete in time for MirAL to land in yakkety.

And I have doubts that Mir-0.25 will land there.

But it could happen.

> (2) Are you sure that consumers of MirAL are also bound to the libmircommon
> ABI? Or do we have an opportunity still to strengthen APIs to ensure that
> dependency doesn't leak into consumers of MirAL headers?

It is possible to hide libmircommon too. But it is an API we really ought to be able to stabilize and I think that is a better use of effort.

MirAL will never be "stable" unless its headers are independent of mircommon headers and so won't be broken by mircommon ABI changes.

If MirAL is sensitive to that then I'd say it should be a high priority to work to eliminate that sensitivity or else we're already making the same mistakes as are in the mirserver headers.

FAILED: Continuous integration, rev:3684
https://mir-jenkins.ubuntu.com/job/mir-ci/1637/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/2050/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2112/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2103/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2103/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2103/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2076/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2076/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2076/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/2076/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2076/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2076/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1637/rebuild

PASSED: Continuous integration, rev:3684
https://mir-jenkins.ubuntu.com/job/mir-ci/1648/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/2062
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2124
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2115
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2115
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2115
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2090
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2090/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2090
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2090/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2090
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2090/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2090
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2090/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2090
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2090/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1648/rebuild

Apart from the abi discussions above (which are important that we get on the same page; I'm probably lagging a bit behing the current intentions in some regards...), this now just looks like a cleanup of the ABI for the 0.25 series, so looks alright by me.

+ __android_log_assert;
+ __android_log_print;
+ systemTime;
+ toMillisecondTimeoutDelay;
seems strange that we still need these symbols, assuming these are something for the input stack (which I thought we were trynig to make into a platform)

If those can be removed then this is the time to try...

The remaining concern is how a mircommon ABI break could break consumers of MirAL (if it uses mircommon classes/structs in public headers). In short I argue if that's a problem at all then it's a problem MirAL should own rather than blocking mircommon ABI bumps.

PASSED: Continuous integration, rev:3690
https://mir-jenkins.ubuntu.com/job/mir-ci/1702/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/2130
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2192
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2183
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2183
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2183
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2158
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2158/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2158
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2158/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2158
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2158/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2158
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2158/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2158
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2158/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1702/rebuild

FAILED: Continuous integration, rev:3692
https://mir-jenkins.ubuntu.com/job/mir-ci/1711/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/2141/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2203
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2194
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2194
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2194
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2169
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2169/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2169
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2169/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2169
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2169/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2169/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2169/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1711/rebuild

^^^
Failures were a network/infrastructure failure as well as the usual bug 1523621

PASSED: Continuous integration, rev:3693
https://mir-jenkins.ubuntu.com/job/mir-ci/1724/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/2155
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2218
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2209
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2209
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2209
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2183
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2183/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2183
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2183/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2183
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2183/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2183
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2183/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2183
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2183/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1724/rebuild

PASSED: Continuous integration, rev:3694
https://mir-jenkins.ubuntu.com/job/mir-ci/1742/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/2180
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2243
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2234
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2234
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2234
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2208
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2208/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2208
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2208/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2208
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2208/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2208
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2208/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2208
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2208/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1742/rebuild

Providing two versions of the symbols seems simpler. C.f. lp:~alan-griffiths/mir/fix-1617865

I agree, if you can make that branch pass CI....

> I agree, if you can make that branch pass CI....

Unfortunately, not without losing the point.

Given that all code affected by the bug is internal and, by now, rebuilt. I'm not sure we should solve it at all if it requires a solution this drastic.

Needs information (from me). This is a simple problem in theory and I don't think we should yet give up trying to wrangle our tooling into submission. It's theoretically possible to fix properly per Alan's above attempt.

Try this instead:
https://code.launchpad.net/~vanvugt/mir/fix-1617865-without-breaks/+merge/306745

> Try this instead:
> https://code.launchpad.net/~vanvugt/mir/fix-1617865-without-
> breaks/+merge/306745

This is worse than that

> > Try this instead:
> > https://code.launchpad.net/~vanvugt/mir/fix-1617865-without-
> > breaks/+merge/306745
>
> This is worse than that

I just realised we can do both. Land the other one now and continue to debate this one (which came up again in the meeting this morning as other people want to break mircommon ABI too).

PASSED: Continuous integration, rev:3700
https://mir-jenkins.ubuntu.com/job/mir-ci/1819/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/2282
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2345
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2336
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2336
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2336
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2310
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2310/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2310
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2310/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2310
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2310/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2310
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2310/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2310
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2310/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1819/rebuild

PASSED: Continuous integration, rev:3701
https://mir-jenkins.ubuntu.com/job/mir-ci/1836/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/2311
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/2374
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2365
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2365
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2365
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2339
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=yakkety/2339/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2339
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/2339/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2339
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=yakkety/2339/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2339
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/2339/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2339
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/2339/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/1836/rebuild

I don't feel we need this branch any more, but bschaefer and anpok (and raof?) have expressed the opinion that they need the break for other reasons anyway.

So you guys can argue with alan_g here.

I abstain but will maintain the branch just in case it gets approved.

Unfortunately we broke the mircommon ABI last night (r3756). So this branch now needs to land.