Mir

Merge lp://qastaging/~vanvugt/mir/crashing-server into lp://qastaging/mir

crashing-server
Merge into development-branch

Proposed by Daniel van Vugt on 2014-04-30

Status:

Work in progress

Proposed branch:

lp://qastaging/~vanvugt/mir/crashing-server

Merge into:

lp://qastaging/mir

Diff against target:

113 lines (+93/-0)

3 files modified

tests/CMakeLists.txt (+1/-0)
tests/fatal/CMakeLists.txt (+8/-0)
tests/fatal/crashing_server.cpp (+84/-0)

To merge this branch:

bzr merge lp://qastaging/~vanvugt/mir/crashing-server

Critical

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2014-05-05
Alan Griffiths			Needs Fixing on 2014-05-02
Kevin DuBois (community)		2014-04-30	Needs Information on 2014-05-01
Mir development team		2014-05-19	Pending
Review via email: mp+217714@code.qastaging.launchpad.net

Commit message

tests: Add a "crashing_server" binary to ease testing of debugability issues
arising from crashes in compositor threads (like LP: #1237332).

Hopefully it can some day be automated with some simple scripted analysis
of the resulting core file. But for now that's not possible while the basic
default server requires root/VT access to start at all.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-04-30:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/1446/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~vanvugt/mir/crashing-server updated on 2014-05-01

1587. By Daniel van Vugt on 2014-05-01: Merge latest development-branch

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-01:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/1463/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Kevin DuBois (kdub) wrote on 2014-05-01:

This might bring up the 'acceptance test fixture is somewhat bulky' topic, but it seems like this could have an acceptance test, so we're not so reliant on using this server to check for how a crash looks, and so the "please crash nicely with debug info" requirement gets tested in CI. It might be more fiddling with the test fixtures, but in the end we have an automated test.

*needs info/discussion

review: Needs Information

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2014-05-02:

Initially I thought that was not feasible because it requires multiple processes and actually crashing the server process. But now I remember our original acceptance test architecture is indeed multi-process, it could be done. So long as you can find _where_ the resulting core file is.

But that kind of automation a harder problem than this manual testing demo. I don't think we should block waiting for a completely automated solution. They're not dependent activities.

lp://qastaging/~vanvugt/mir/crashing-server updated on 2014-05-02

1588. By Daniel van Vugt on 2014-05-02: Merge latest development-branch

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-02:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/1491/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Alan Griffiths (alan-griffiths) wrote on 2014-05-02:

It is always worth investing the time to automate testing for desired features.

review: Needs Fixing

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2014-05-05:

But that kind of automation a harder problem than this manual testing demo. I don't think we should block waiting for a completely automated solution. They're not dependent activities.

lp://qastaging/~vanvugt/mir/crashing-server updated on 2014-05-05

1589. By Daniel van Vugt on 2014-05-05: Merge latest development-branch

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2014-05-05:

The above comment should be in quotes (LP stripped them), referring to comments from 2014-05-02.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-05-05:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/1513/rebuild

review: Approve (continuous-integration)

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2014-05-09:

Come to think of it, if we replace the unrecoverable critical exceptions in the compositor/DRM/KMS with "errors" (abort etc) then this proposal wouldn't be a valid example any more. The throw would need to become abort() or some other raise().

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2014-05-22:

Work in progress (possibly indefinitely). This branch:
lp:~vanvugt/mir/fatal-error
will introduce nicer automated testing of crash handling.